From: "Matias Bjørling" <mb@lightnvm.io>
To: Wenwei Tao <ww.tao0320@gmail.com>
Cc: linux-kernel@vger.kernel.org, linux-block@vger.kernel.org
Subject: Re: [PATCH 1/2] lightnvm: use rrpc->nr_luns to calculate the rrpc area size
Date: Thu, 31 Mar 2016 15:25:28 +0200 [thread overview]
Message-ID: <56FD2548.1080607@lightnvm.io> (raw)
In-Reply-To: <CACygaLDKuVvK0uH=iJ7d=JJGZtkzY10F=YQ-eJ64Xkk6M+EpyA@mail.gmail.com>
On 03/31/2016 12:26 PM, Wenwei Tao wrote:
> This is okay with me.
> By the way, why don't you like (sector_t)dev->sec_size *
> dev->sec_per_lun * rrpc->nr_luns, the change seems smaller?
Both works. I wanted to fix the underlying issue (which was rrpc values
wasn't initialized enough to be used). Back when luns could be of
different sizes, it made sense. Now that we can have the values up
front, it makes sense to use them. :)
prev parent reply other threads:[~2016-03-31 13:25 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-30 14:28 [PATCH 1/2] lightnvm: use rrpc->nr_luns to calculate the rrpc area size Wenwei Tao
2016-03-30 14:28 ` [PATCH 2/2] lightnvm: use relative logical address in rrpc_l2p_update Wenwei Tao
2016-03-31 9:11 ` Matias Bjørling
2016-03-31 11:09 ` Wenwei Tao
2016-03-31 8:31 ` [PATCH 1/2] lightnvm: use rrpc->nr_luns to calculate the rrpc area size Wenwei Tao
2016-03-31 8:57 ` Matias Bjørling
2016-03-31 9:51 ` Wenwei Tao
2016-03-31 10:07 ` Matias Bjørling
2016-03-31 10:26 ` Wenwei Tao
2016-03-31 13:25 ` Matias Bjørling [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56FD2548.1080607@lightnvm.io \
--to=mb@lightnvm.io \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ww.tao0320@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox