From: Jon Hunter <jonathanh@nvidia.com>
To: Mark Brown <broonie@kernel.org>,
Laxman Dewangan <ldewangan@nvidia.com>,
Thierry Reding <thierry.reding@gmail.com>
Cc: "Maciej S. Szmigiero" <mail@maciej.szmigiero.name>,
Lee Jones <lee.jones@linaro.org>,
Stephen Warren <swarren@wwwdotorg.org>,
"Alexandre Courbot" <gnurou@gmail.com>,
<linux-tegra@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>
Subject: Re: Tegra boots failing due to as3722 I/O errors
Date: Thu, 31 Mar 2016 15:45:14 +0100 [thread overview]
Message-ID: <56FD37FA.8010005@nvidia.com> (raw)
In-Reply-To: <20160330164646.GH2350@sirena.org.uk>
On 30/03/16 17:46, Mark Brown wrote:
> * PGP Signed by an unknown key
>
> On Wed, Mar 30, 2016 at 02:15:16PM +0100, Jon Hunter wrote:
>
>> On second thoughts, is this the correct way to fix this? I see that
>> there are some operators defined for get/set_bypass for a regulator and
>> these are not specified for LDO6 either. However, even if they were I
>> don't believe this will fix the problem alone.
>
> If this is trying to implement bypass support it should use bypass
> support (and the other things doing this fixed to do so).
I have created 2 patches to add bypass support for LDO6 on the as3722 [0].
>> The failure is caused by _regulator_get_voltage() returning an error.
>> This function does not check if the regulator is bypassed, but I am
>> wondering if it should and then return the bypass voltage?
>
> Yes, like we already do for switches. I'll send an untested patch
> shortly.
Thanks. I have tested the patch, but as I mentioned in my response, the
issue is still not resolved even my patches for as3722. Hence, I have
not sent out my patches yet (although I verified they are working and
detecting bypass correctly).
Unfortunately, I am leaving for a weeks holiday starting tomorrow.
Laxman, Thierry, if you have some time to look at this over the next
week that would be great. Otherwise I will pick it up when I get back. I
don't think that it is too hard to resolve, we just need to add support
for bypass on LDO6 for as3722 (hopefully I have done this now) and then
ensure the bypass voltage is read correctly when registering the LDO.
Mark's initial patch to do this [1] is not working so far.
By the way, this issue has been recently exposed by a change to the
regulator core (bisect showed the problem is first seen after commit
fa93fd4ecc9c "regulator: core: Ensure we are at least in bounds for our
constraints" was added).
Cheers
Jon
[0] https://github.com/jonhunter/linux/commits/as3722
[1] http://marc.info/?l=linux-kernel&m=145935914903138&w=2
prev parent reply other threads:[~2016-03-31 14:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-29 19:03 Tegra boots failing due to as3722 I/O errors Mark Brown
2016-03-30 11:31 ` Jon Hunter
2016-03-30 13:15 ` Jon Hunter
2016-03-30 16:46 ` Mark Brown
2016-03-31 14:45 ` Jon Hunter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56FD37FA.8010005@nvidia.com \
--to=jonathanh@nvidia.com \
--cc=broonie@kernel.org \
--cc=gnurou@gmail.com \
--cc=ldewangan@nvidia.com \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mail@maciej.szmigiero.name \
--cc=swarren@wwwdotorg.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox