From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757215AbcCaQDl (ORCPT ); Thu, 31 Mar 2016 12:03:41 -0400 Received: from mail-bn1on0055.outbound.protection.outlook.com ([157.56.110.55]:12406 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751359AbcCaQDh (ORCPT ); Thu, 31 Mar 2016 12:03:37 -0400 Authentication-Results: spf=fail (sender IP is 66.35.236.227) smtp.mailfrom=opensource.altera.com; arm.com; dkim=pass (signature was verified) header.d=altera.onmicrosoft.com;arm.com; dmarc=none action=none header.from=opensource.altera.com; Authentication-Results: lists.infradead.org; dkim=none (message not signed) header.d=none;lists.infradead.org; dmarc=none action=none header.from=opensource.altera.com; Reply-To: Subject: Re: [PATCH 6/7] ARM: socfpga: Enable Arria10 OCRAM ECC on startup References: <1459351668-14622-1-git-send-email-tthayer@opensource.altera.com> <1459351668-14622-7-git-send-email-tthayer@opensource.altera.com> To: Dinh Nguyen CC: , , , , , , , , , , , , , , From: Thor Thayer Message-ID: <56FD4B6C.3070608@opensource.altera.com> Date: Thu, 31 Mar 2016 11:08:12 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [64.129.157.38] X-ClientProxiedBy: BY2PR1001CA0024.namprd10.prod.outlook.com (10.164.163.162) To BN3PR03MB1477.namprd03.prod.outlook.com (10.163.35.140) X-MS-Office365-Filtering-Correlation-Id: f9915c18-2636-4bfd-5c8e-08d3597e0193 X-Microsoft-Exchange-Diagnostics-untrusted: 1;BN3PR03MB1477;2:/b4oCmU4g92SGI2NZCKJhaNCUx7BwGOwTd1x+RRdTO6ZX6Af96+p0KPlqNt2hkygdBlU7nkz10Bkpg+2I9ngSHIuvZBEPrfCkbAg2VNn56mca1xuCgDE7FZUQlS+4cyCVQGBIm6jw4r+/gRSYuvO9vWSupcALTrCwyYeNnqPh+i8DrfS3h3wC+n2jOYBjAWo;3:qPdGfKcdW+UwMW1d4ld+SU49aUhJj6uGTk9OCUt8U/YH+Re/gFdbKpltXGb2nZ+kCWSlSAAdRsM3IMyTTiqLVircSRuUTX6sxSCo0qXWhmMswYqa7e3a2p4Fsjiq/S5Z;25:0dlgm525bLmJ6c2VcwN+VHnJW561GSe4K1tqg4z3WmBYQEotSBrYZi4jIL9eC5k1ayYF+TGzgqUzPvDJmr+90ALU08/jxmIj37aarjFEDOzOqsfcUgZD68/7k6vX0q4oVhAulwrjCc0VO9VNfDSZ5l30jBro1ZOqTU1rCIF4jVKRRrkoRDSCEGzYwSv7+4gBdGdFuCVs1ZFpX9mPAOnw/H2BrksuDEMOHlZu6WgPRSxfiD4A6Gw1JimpgWup8PL4uObcSFpdzGJ0YAoPzGuhBodhoPqNJRxPJXnx8+n4h4Wr2DAdqWBHXERIc4uIeN2qcqnM+NXtAcof98TXhKKUDUPJySrMtMTBqnLsdYy7ofiUKy3pn1Z9RW5XRlIOZUifkA+I4fOeOekh9s2hi+Y24diJnhRkzGI/YshIXxMqPs7ujioNvwxouxPhRrLCMWBa6OuO2/q+PErIUWvQmcQ9PTJR+LX9or/jAGi/EXb3UJs7aGMNAv5z0O+3xjmN1mdjEBJhFWM1Qy1/I6v3eSekwM8ZrBDo9pKc+jKHq8Bw1pZal9XSlEA5qWN+e0a87WsmJ3J45HGPQH9OcMi0HWnyzIWYFyIDHAuFA8XsJUAPUfVGbRh+U8Rb0lH4nRiC/S4+ X-Microsoft-Antispam-Untrusted: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BN3PR03MB1477; X-Microsoft-Exchange-Diagnostics-untrusted: 1;BN3PR03MB1477;20:lewNaG8F06tZBBC/sOz0nRDhLrOYK/ft5+h1CpiYptUUZDZORTT8XhjLey3AjFb1Twn/Yx4JiEv2VT4CRTggQDDFpwJ+70ztATo8PK7sykGxU/+7kxbaN5D7uNztDmJ3tH7lTVRRXG8Y+c4NIyvYkKhHQ+NlKLCDDgboZ0hIkok=;4:JKjXKa2ZxIgeIq24pKNsqofvDOAYtCTKUYuJmdC1mqoZ6ZG+EPJMAgQy8NDaAQb3Pl7wwKWfTJ1f/x8qHmNn9jIWZXnKy5MqO5Sv0X9euLKgy5IO3b+pWS2SMQhYLmT3pcDo79o7MQkK9NTETP3jtF2gI247ynHP+3DQlOOLcz1m/5qv+FcjhbJLfjdkm2q9U1k0/4Iu5fQLPawSM0RxgHeXhmaG7zTD+f1FNyc2fD6HVpOsdc1nymyHiS1gvxjEr0zm7oIKV/7IBS43CAnLE9ziMYl4N2jJ+vf6i4VvxfK5hxGWp4pYBImflYspqQ4cN0laeYb2OJYZcP/4FprMbkIXm4iBNHGUtR4i+OUsNdT7/BS1ytc+hOvHCenYjtfv X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:;UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001);SRVR:BN3PR03MB1477;BCL:0;PCL:0;RULEID:;SRVR:BN3PR03MB1477;BCL:0;PCL:0;RULEID:(601004)(2401047)(5005006)(8121501046)(13015025)(13017025)(13023025)(13024025)(13018025)(10201501046)(3002001);SRVR:BY1PR0301MB1285;BCL:0;PCL:0;RULEID:;SRVR:BY1PR0301MB1285; X-Forefront-PRVS: 0898A6E028 X-Forefront-Antispam-Report-Untrusted: SFV:NSPM;SFS:(10009020)(4630300001)(6049001)(6009001)(377454003)(52604005)(24454002)(50466002)(6116002)(586003)(81166005)(3846002)(1096002)(65956001)(66066001)(65806001)(42186005)(86362001)(54356999)(87266999)(43066003)(110136002)(47776003)(76176999)(53806999)(3450700001)(19580405001)(80316001)(19580395003)(65816999)(4001450100002)(189998001)(23746002)(50986999)(2950100001)(2906002)(77096005)(4326007)(33656002)(5008740100001)(83506001)(5004730100002)(230700001)(4001350100001)(64126003)(217873001);DIR:OUT;SFP:1101;SCL:1;SRVR:BN3PR03MB1477;H:[137.57.160.203];FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Exchange-Diagnostics-untrusted: =?Windows-1252?Q?1;BN3PR03MB1477;23:9t40ekd28QCDYfcsXTEtSa7z+WeAgUboMIJ2f?= =?Windows-1252?Q?k1hYA0au9JdFtw8lim+bsuemb5PrlPfbGIW1pxZitEu05N5Hu7db8DuD?= =?Windows-1252?Q?xMggE0BDta8Fz4MfX9XuLs9tXwqBxZwelpwAPNauFolFab4BYhUj8jM1?= =?Windows-1252?Q?bkr+oxsF5b1dJ1tTvk0okTNP7wpsKi3FiM+tx4rFphC7XRYw6NKE3Pq4?= =?Windows-1252?Q?j8dtO25ajrU0eaMMG3ZzHZlBCQSvMHPcZnzJcUXDWU6msSqAJrgpbhsM?= =?Windows-1252?Q?ImYmYyUDpK9RRpuBkwAgAuIwxLhBnZIwAQPbXcRraRK3C0yizNvVBTWL?= =?Windows-1252?Q?FKQ/sknSO8iPtTbdPRmH0TAuDLQRbv84lz8ZlmwnQKPHhBvwRnxDL9N9?= =?Windows-1252?Q?Bbzd/yV+xOiJLUH387eb+lcL65o/mlXR2eFADKGQXo+OO6yFbNkNaJ7u?= =?Windows-1252?Q?TWg7VvlZY6oWsFzNpGFU+RqIS5M2BJnArbsIpYeU6UkwWCrd+ZUPKzxf?= =?Windows-1252?Q?w/LkIpAeuxuKZ853QtGHKmjOZg08c8B2o3HapnzVEoXBzgAz9sMiGw1o?= =?Windows-1252?Q?yNQoo8pV87X6m5uBPmHOhCSq0x4Byf86QLN/11eoBwdPFgXLBitQuAuo?= =?Windows-1252?Q?t9uFGTcdI8BDy259XJhISKQTG3qZwDMJ+BjbhNwl8/r7uo7NE2amBJ/L?= =?Windows-1252?Q?L4c1L/QdZrm35JpubgXx2cIAAhb3LKHCZf5Fxk3ZlmmAfeLusqlC9Ff+?= =?Windows-1252?Q?8mJobbpShEt2Z4t59eC8j17Q7NB3XubuEEu1yFrddgo5i0vpQAfs+bWe?= =?Windows-1252?Q?EH3hHolTvCxdM3WQnaL4klUwr1syiYnAlWE2MMw5ZqAyJliZ10lKObtk?= =?Windows-1252?Q?ScUuyPRlbxHDsu1rrMWhv2wFyOW78UIb0ob/UpFsflC6+Mg/nRTTUOv6?= =?Windows-1252?Q?a3R+8QszMkDKKCp60A74Eula2kKhQwArtHBbiQxLJ1DTHzXT3RfpVL9C?= =?Windows-1252?Q?808v6pDZxG7N7UAwVfTGk9vjobQh7MNEW8zeAqr5dT3v8Imnibauy/2a?= =?Windows-1252?Q?4OSdi7qPMui/Uq2OVrxknRajgXRXAioUOg8LSjQJA7r6u8jXPwM/L7Qu?= =?Windows-1252?Q?SgeW5U1Y/WmQ1+0X14Zv2VYtX9LmLDNPOklCGp4nbmMPkIRufjDEnUNP?= =?Windows-1252?Q?WgjWUu9sqQJ7Wx0IgVknu07t3fqloVnKo9CC5hB3LgBG0ueiGzYEBRfc?= =?Windows-1252?Q?+i1i4q049Mi+Q1deI9gntHREzhMF1/d887xc9E=3D?= X-Microsoft-Exchange-Diagnostics-untrusted: 1;BN3PR03MB1477;5:ZJLrqWvU3OD8FhJL0gPI1L6qugVa+FxKs02cp3FDhedqW1P/b6ib+P5rdUa0eDm/JrOQYty3ArcdxI72dqpb9cTmk5EAEqe730GXUthUtYYpAk1BXdkQC6BawH9DNP1dD/kWyjbWySElaVrHslxTEA==;24:lbBe5GgIh2nu4yovk0XjHxPytZtewIY6vY/t3cTobOEAwRyHxoL6KlxTbXZvkyZSJaT67Lvr7HL91SvH6k2rslVoA8rnCzX44+gNFc/8NVU=;20:ewlWW/JFrAsg8SBDvM1AkSMBJ5XabqplE2DcWDsj1sBN02HkhhjuVkAauWK9A9E4A+aV7jMAS+reEbV+5Ky5Tziao6XBX9eZgEbNqa4SZEOFZZUrStrgjtQLnZ+GnL9GiFY1vQjzAVQgu0ISZlCF2DnqEWf08WwwBxBY4B3wSns= SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN3PR03MB1477 X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: BY2FFO11FD021.protection.gbl X-Forefront-Antispam-Report: CIP:66.35.236.227;IPV:NLI;CTRY:US;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(2980300002)(1109001)(1110001)(339900001)(3190300001)(52604005)(377454003)(189002)(24454002)(199003)(16796002)(50986999)(47776003)(3450700001)(83506001)(80316001)(65816999)(5008740100001)(4001450100002)(105606002)(19580395003)(3720700001)(19580405001)(66066001)(87936001)(11100500001)(65806001)(65956001)(76176999)(64126003)(106466001)(4326007)(53806999)(6806005)(87266999)(2906002)(54356999)(81166005)(85426001)(956001)(586003)(50466002)(2950100001)(1220700001)(6116002)(110136002)(23746002)(5004730100002)(1096002)(3846002)(77096005)(43066003)(4001350100001)(86362001)(21840400001)(230700001)(33656002)(189998001)(7099028)(217873001);DIR:OUT;SFP:1101;SCL:1;SRVR:BY1PR0301MB1285;H:sj-itexedge03.altera.priv.altera.com;FPR:;SPF:Fail;MLV:sfv;MX:1;A:0;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;BY2FFO11FD021;1:sVhKnpe1W+kJyOjxYRjSX7A3FLzlik0uhhAtasBzVDhBv4oJB9NkKEvDCF2e3EVRMH8+nLAtwKdLRggnS4SIa/0y+LI1cbUQ7Bws9uRBB3w/qYGtqhmEiphcAU/VSoKDKfHBFXwaUCO60gMnCQN5lWX3Tmd2G1fHL8ID7jL2DqDi6CocHcnUO/dq5LW0wykH/IyUjZ2DQ491A4ZsXQNO3G9NaDOPdLVlgMJQtd0TDYvq/OtJTOraSJlH2Imed7phI2ucTXn+FxM4eeJWLmmE5/VbUdR5xsOkPbAisTSvXp/Nmx1S9HBFIdX1TXIDX3fo5R0NzmKru6+Mqxwps/PaoLHvmXsRUaiAlA8DK+G88OmtE40OzoT/eLPsZx+t6EHafzaV+k8YcBpCEV4UVPDFIOyvUNEzw/w9PkztjqzQNwDh+YjWsTRa5bgMEL3XdeOe7IJNnoZW4emrshUQmmvP3rCGvDARpoXLSluKedAWdwETUNTf8BSeh+cVFxuWNRNhma8igvjO3vBxbCL6lA7bvuqlPMmV0ToKicxtXuS9Y99fdTMGPg/UaE2j90VcmwWV X-Microsoft-Exchange-Diagnostics: 1;BY1PR0301MB1285;2:O7bQofbqVksRvS69msiQOF/kShI7Brszhm6NbqCF7xF7q8TJ+d+g2Ehau2ejo9G/E88T8wA1JmuEKLZI06pyCWTxCTVHlD7yT/i6Y1pXIelV8X7QnqFTMpktIyKCgn2C6YKihcfWP0Qt8oBTgybLxIIaoXdgbhDG0nq++F6ABGz59akCGvZvn6sZID9lOjf7;3:yR0qWgCzExQ76GpPQChKVHiWxmujag7TM9EusI+9idOYQ6ZPd+4uDQQ47z2pjvyR+Uon+PP7AtXuh14iGqoLsHdMNm1MhK5GS47a88DadW2YFrqX7Bo/yNSxGJzfGCJx2yF21QX7h2DEsGISX68htaBiVHX/f+t7wzVQU0DEWboxlaLTqzzl6eJ6cTiscs7RkvDaRRhd6u8FvKSkiK/T3KVhZ/nxkVoWzu8Ut8ufwTeVApN0dfNlewujaOkMHABs X-DkimResult-Test: Passed X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(3001016);SRVR:BY1PR0301MB1285; X-Microsoft-Exchange-Diagnostics: 1;BY1PR0301MB1285;25:TPUWSZ5DIy/PKgMu0llLaYwRkgopnpwC2OJN9W1wJe8axVXOGNGZopTJhKikPJCMDQafqHjnQxuIoO37z0GatgcK6U6+s6xxnf9NnX4yw1qh6gGgSSDBkAshgRybZOvUCSEFow/4IGJK6NqkoS3p63m9GSmYILO5xCAxeh8ZSXwlHGtqLHsSb+0+VGCWl9RZYIna/3d9fdk3SERtONsTlPCGW1LMAwXOhvN70EYa9v17EqeNe0NFc40KkYcihcYr7zIJjAUHW5ZhUr6hb5HfR//4lE7DKQ7O5DvByhxKGqjGwGZE6NXmVhhK83D+xbcrSj+wB2SRw32a6pn1rTJ+ZQmjTOxqlPduhgmAm7sEc2HqJY2p2i/NOwnUC3blrJdKwEwo+yBXwWUMwUNZCN2+NV1lK37Ymu1zU+OQ3WzZQo4SE1GG3d93qrRIf+iTsRVgJeBOBD5zu44ChS40P0u8wITaIR3oF52LzjfoU7Ms2P4Ejo9ztpKhINwM06Y4PvI+h9XcZ68AHvNZDZrHH3rEU4K2QjyhIax2hCt5fxb361s3VfXqRvumWqIU48kDXQrWj+2bmOAbmTtd5PAJ62ZqOFO5T20RzsF7km+okrsqsYJEMEF6I+db/VMb3X77THQ/tGfKMtaqT5oC82RApj/BwA==;20:6ZvP/Gf2YLrmGJTlfoBzhGUX2wRs3PtpgGOyrTNjp36LM41wlQ+Lyngu6reRIOydOk6FnE3jKhVA9ygy1JM7Ib58Q1iXxZ8eJsoxrq6OdLKQhB8mUyKAlxxTFDvbxDR/sTyDfvnHX/YRB/FU4I4NStMq2JUzGdaqURnbyiX/KGk= X-Microsoft-Exchange-Diagnostics: 1;BY1PR0301MB1285;4:btEG7brkxhgjdARsbqoygIL7AQq4OMaamLxdYiKjtunTeBG8Fod75Xk8QdPrbICLUwgAYb9s7HiKXsYlVgnoZS2zy2B7lEf8CM2pf9rixBSwi8h7GShwT4rDHyXpRZ4Ghpiey+7OccZCtDLB9mK/GZ/4/Fr6La2LJOnhSowOeBao6jlW6dICbVn44bVBcD/HcoRy2QzmcoG3DU4Y9S3C07ln1WSG6/Z4wT8BfRWlifiQyFk+zQzCAFpvrSPSiaEGoALjFha35SxXc9A+VGbnBrb8HmyUvqpFAs5syv2qycgj8hfvDbs4bFbWCGzFP4YGskMIFl50Q3e/QlV8eC5Z2PwVSAuR/cBZzkiIsOhGCGbBc/MKYny94Hb3LVT0/yx0FUl1WT4k9J6wmhCMkkiGrgiYPoQ/VUrOkN5oBFkSTrSwzpx3qTaGQLa5c9h5AXIpPShaqw7v1iKaXGRPpFa3yQ== X-Forefront-PRVS: 0898A6E028 X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;BY1PR0301MB1285;23:3wsLS3eml6U9yKVobM/KIc15+2/ZyYozRor?= =?Windows-1252?Q?pjM53kn/Bfm/aUQKNQeZOptPN1w7XiZcYMmWccHZiwBbKcULav2Lq2ky?= =?Windows-1252?Q?31RBrxFGhIOknUxDwz722z6UQRdXeHQTvU2eQYBBDSGZfh9zXS7l58A4?= =?Windows-1252?Q?rN5+RyYBANUNd7vkE4VEZYQ4xqdx3DOCWf6aiCZ2gkR1Z7Kb0dT+mDuH?= =?Windows-1252?Q?uOCqG/2DVovSdkqHb0h7Vj3bpb5w7fUwZUnsbOvmB2r9T5TZvB57fQHF?= =?Windows-1252?Q?tKVTO0WJYlcD+n0rfyU2eBdwHn1xA33naGymCvE2TZgu5gcgeJB1iTgv?= =?Windows-1252?Q?y2mpD0mOdoqs4CH/v6ADComXnd6+mrmK3LPRghQedtxCSexNHNB+zhdN?= =?Windows-1252?Q?tbl/eLHYx1+QFuXwQ6BGcIsFoQur6S6fBo/qsZgUDV+B5D5ds9ewpxya?= =?Windows-1252?Q?m5hLmpmq0aMX/9kVo+qZXCwiC3DKFgG0mr+V4rmWvyg58Rfhxk25cmVq?= =?Windows-1252?Q?ZXbN8C0954mMsHOEcipYWn+J0Q9fwwJlvQnxE0Dp/MBzI9p0lbg9VzFq?= =?Windows-1252?Q?Qq+/46HuQrlAlSD1RKKb+BpUERvGusEHclhQRopCzRheBuHw/vE3+30Q?= =?Windows-1252?Q?6pgsHyDvbhaoiReaI/JsGjr7539aW4cKA2nGOpNoNik6e8wM3NIeSSYi?= =?Windows-1252?Q?84FiGuP8ZTZnMAKYrfTBETwKQvyKAZdipwPPUGUMsMXHEsopo/8haWMn?= =?Windows-1252?Q?7RqckXufa8awM/NysHSt6HD6HaPnzMompUYWI5at0WcJMelEhPoazPAf?= =?Windows-1252?Q?CMsRjP9VwgNojHk/1SooWVVnFNbR7fMV48/9bqEc1uT0cuN+crs/U6dd?= =?Windows-1252?Q?9uP3v9e4QgnHNf/BfS1ER/KVmV+573Ft22h4uYoDiSlf5ZewNlVsQs+B?= =?Windows-1252?Q?46iAtESmCaet3WDh6/wYSSd3VSMbmJPcQqq5/QoiH+Fhpg4hBHts5iHx?= =?Windows-1252?Q?HgeYT0F3vkISlnahjdOFtL3TN/Tzw2Cp6l2KYNf2VsepIXikPYbMR8vT?= =?Windows-1252?Q?zk20Rwk4aP5YGm0PDDcELAiG9RvO0Ydl3TV2nvtdgsxW0W/9dXavfz+E?= =?Windows-1252?Q?to4DwwHCE/pJ147nF7soXqc30MXBKQtVmPiom6JUV1Cr3pVs7xQnYpft?= =?Windows-1252?Q?mw6IfcM8FPofqldKopVEo/ILb/pMBPUhYCzdIqN7Hf8DIwj2ks6r3ySE?= =?Windows-1252?Q?8fKs7utEmB01ogpzQFWlPANUu/Wt7bhh6uuEhRZX/HeLQ5U7aVWkeaWR?= =?Windows-1252?Q?E6fGP2vWMTpmuw5hlKMfJ+rULSaf/kE4TOoQNHqK6UWY1ZkcKulfOIcZ?= =?Windows-1252?Q?DVAJ/qu3bPBhv/YZw9VZkKlQkJAmqbfBZ5UY7RjAm/Qq5u3bxyA949mp?= =?Windows-1252?Q?0PFBf/DPOQjf6LFmuCFUE+JIVshTmgtlXhabS7OqrQcW2tjWl9Ut0vQi?= =?Windows-1252?Q?w8neYyuCmKy7O5olYdJnxDn9ocnYRf7isDMX2xyiTX+7t2y7DuO8jyyX?= =?Windows-1252?Q?8nfEBkNH93Uiz50AkHU5b1SpSGIumG2Q0Zh5OwCIWLdGLD/BarPum2CU?= =?Windows-1252?Q?IFwMeTRUNiRcQzRsrXdLNXKBBTs895qaaBztecG7/RszB?= X-Microsoft-Exchange-Diagnostics: 1;BY1PR0301MB1285;5:s/cJbTY8EMIU0jroHjj/Wh+iH6mj6tuaYqFKw6HroGGRh+JHK39h/Fwb48ApqHpzlaNYC2u1aHVAqtr12MRifYrnPQFFe0IbL7txBcKKGtRXl+/Z3CyZK4uGSbpquen2JL9/NG7pjNNHgXwub8Z7eg==;24:LUFpDorSFejNYn5l2pvJI5gK1biwT8BDxOAYtNRfEVTRUGU4xwjK8YqA/ynTQEdZuOuvQ+aqra75+I8w15VC8mWMwIN7XzYpUg9mt6GI0X0=;20:Fl6bPHJpe621guotSZeYOVQLPLQuv1Hq9IV7Gd0siootTFoZbg6F07ziG/NvOo1c7k+TiNovtH6xhLEhb/exvvmrsLmb4bmB5h0cFDqlKT+NHx9h6WlmYAOSDJHIWXV+plmYUEm7pbAE8Q+wELJbAbkUNo4yVNCEvKwt+r5Oj88= X-OriginatorOrg: opensource.altera.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Mar 2016 16:03:31.4373 (UTC) X-MS-Exchange-CrossTenant-Id: fbd72e03-d4a5-4110-adce-614d51f2077a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=fbd72e03-d4a5-4110-adce-614d51f2077a;Ip=[66.35.236.227];Helo=[sj-itexedge03.altera.priv.altera.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY1PR0301MB1285 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Dinh, On 03/30/2016 12:11 PM, Dinh Nguyen wrote: > On Wed, 30 Mar 2016, tthayer@opensource.altera.com wrote: > >> From: Thor Thayer >> >> Enable ECC for Arria10 On-Chip RAM on machine startup. The ECC has to be >> enabled before data is stored in memory otherwise the ECC will fail >> on reads. >> >> Signed-off-by: Thor Thayer >> --- > > [snip] > >> + >> +void socfpga_init_arria10_ocram_ecc(void) >> +{ >> + struct device_node *np; >> + int ret; >> + >> + /* Find the OCRAM EDAC device tree node */ >> + np = of_find_compatible_node(NULL, NULL, "altr,socfpga-a10-ocram-ecc"); >> + if (!np) { >> + pr_err("Unable to find socfpga-a10-ocram-ecc\n"); >> + return; >> + } >> + >> + ret = altr_init_a10_ecc_block(np, A10_SYSMGR_ECC_INTSTAT_OCRAM, >> + ALTR_A10_OCRAM_ECC_EN_CTL, 0); > > I think this is a no-no, you shouldn't be making a call directly into the driver > from here. > > BR, > Dinh > OK. I'll make the initialization local and resubmit. Thanks for reviewing.