From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757468AbcCaXUA (ORCPT ); Thu, 31 Mar 2016 19:20:00 -0400 Received: from mailout2.samsung.com ([203.254.224.25]:47032 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752573AbcCaXT6 (ORCPT ); Thu, 31 Mar 2016 19:19:58 -0400 MIME-version: 1.0 Content-type: text/plain; charset=UTF-8 X-AuditID: cbfee68d-f79e86d0000012da-7c-56fdb09b5ce7 Content-transfer-encoding: 8BIT Message-id: <56FDB09A.8000202@samsung.com> Date: Fri, 01 Apr 2016 08:19:54 +0900 From: Chanwoo Choi User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 To: Nishanth Menon , MyungJoo Ham Cc: linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Grygorii Strashko , Tony Lindgren , Lee Jones , Roger Quadros Subject: Re: [PATCH] extcon: palmas: Drop stray IRQF_EARLY_RESUME flag References: <1459458951-4882-1-git-send-email-nm@ti.com> In-reply-to: <1459458951-4882-1-git-send-email-nm@ti.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrDIsWRmVeSWpSXmKPExsWyRsSkUHf2hr9hBtf6dC1WTmGxuP/1KKPF psfXWC0u75rDZjF7ST+Lxe3GFWwWb36cZbLoeaRlsf+KlwOnx7evk1g87lzbw+axeUm9R9+W VYwex29sZ/L4vEkugC2KyyYlNSezLLVI3y6BK2NG71fGgsdGFdcfTmRrYPyk2cXIySEhYCKx e1szG4QtJnHh3nogm4tDSGAFo0T3rFvMMEXrH1xggkgsZZT4ceQIC0iCV0BQ4sfke0A2Bwez gLzEkUvZIGFmAXWJSfMWMUPUP2CUePpmBSNEvZbEnL2fwIayCKhKzDryGsxmA4rvf3GDDWSO qECERPeJSpCwiIC7xP/jz8AOYhb4zSixat1fsEuFBdwkDsz/zQRSLyRgIXGwhxMkzClgKXF9 TgPYnRICL9klri+/yAaxS0Di2+RDYHdKCMhKbDoA9ZekxMEVN1gmMIrNQvLNLIRvZiH5ZgEj 8ypG0dSC5ILipPQiQ73ixNzi0rx0veT83E2MwEg8/e9Z7w7G2wesDzEKcDAq8fAazPwbJsSa WFZcmXuI0RToiInMUqLJ+cB4zyuJNzQ2M7IwNTE1NjK3NFMS51WU+hksJJCeWJKanZpakFoU X1Sak1p8iJGJg1OqgZGlMvru0rk90wM4FGVn79vLf8kn8fbzc4+ad6ot+nXE3X9y37W4vz5H jlSXpZ99peCV6K3kuTTRaCPj/3OrZNRmWpzjCmfdGTI7kXdd7llxg6sKs1ZqPcpklQi/n3lK gUOvi/0Bq1ZTQo8ft8lX+VVZ66cYWKzLWnxm0+GVaXeEs9asl9hk56zEUpyRaKjFXFScCABh pUYTvwIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrJIsWRmVeSWpSXmKPExsVy+t9jAd3ZG/6GGez9omaxcgqLxf2vRxkt Nj2+xmpxedccNovZS/pZLG43rmCzePPjLJNFzyMti/1XvBw4Pb59ncTicefaHjaPzUvqPfq2 rGL0OH5jO5PH501yAWxRDYw2GamJKalFCql5yfkpmXnptkrewfHO8aZmBoa6hpYW5koKeYm5 qbZKLj4Bum6ZOUAnKSmUJeaUAoUCEouLlfTtME0IDXHTtYBpjND1DQmC6zEyQAMJaxgzZvR+ ZSx4bFRx/eFEtgbGT5pdjJwcEgImEusfXGCCsMUkLtxbz9bFyMUhJLCUUeLHkSMsIAleAUGJ H5PvAdkcHMwC8hJHLmWDhJkF1CUmzVvEDFH/gFHi6ZsVjBD1WhJz9n5iBrFZBFQlZh15DWaz AcX3v7jBBjJHVCBCovtEJUhYRMBd4v/xZ2B7mQV+M0qsWveXDSQhLOAmcWD+byaQeiEBC4mD PZwgYU4BS4nrcxqYJjAKzEJy3SyE62YhuW4BI/MqRonUguSC4qT0XMO81HK94sTc4tK8dL3k /NxNjOBofya1g/HgLvdDjAIcjEo8vDem/Q0TYk0sK67MPcQowcGsJML7aCVQiDclsbIqtSg/ vqg0J7X4EKMp0HsTmaVEk/OBiSivJN7Q2MTMyNLI3NDCyNhcSZz38f91YUIC6YklqdmpqQWp RTB9TBycUg2MB/Pn95oc6D4VrV/8YJ5U+HPLQ1KcKiU/Cz536J39Y/1FbkXW4nUPexhfHG+X O3Hj5gGB77Znss6If7greC6v57CJSu7ficptcgKBzI4FYmwcmm+NvVcUNcyLf/962rRjC7da Odat7Kxm7OnwNfTWS3+0af6JxyfX7BD8Ni9FxP213hzJY8rSSizFGYmGWsxFxYkAAuQQmAwD AAA= DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Nishanth, Don't need to add the IRQF_ONE_SHOT flag for "palmas_usb_id" interrupt? If don't need it, I'll merge it on extcon-fixes and then send the pull request for rc cycle. Best Regards, Chanwoo Choi On 2016년 04월 01일 06:15, Nishanth Menon wrote: > Palams extcon IRQs are nested threaded and wired to the Palmas > inerrupt controller. So, this flag is not required for nested > irqs anymore, since commit 3c646f2c6aa9 ("genirq: Don't suspend > nested_thread irqs over system suspend") was merged. However, the > fix missed a stray flag causing the following crash on resume on > BeagleBoard-X15 platform: > [ 53.670141] Unhandled fault: imprecise external abort (0x1406) at 0x00000000 > [ 53.670141] pgd = ecd30000 > [ 53.670141] [00000000] *pgd=fe3c1835 > [ 53.670141] Internal error: : 1406 [#1] SMP ARM > [ 53.670141] Modules linked in: xhci_plat_hcd xhci_hcd usbcore encoder_tpd12s015 connector_hdmi omapfb cfbcopyarea c > fbimgblt cfbfillrect evdev dwc3 snd_soc_simple_card udc_core leds_gpio gpio_fan cpufreq_dt omapdss snd_soc_davinci_mca > sp snd_soc_omap snd_soc_edma snd_soc_tlv320aic3x omap_wdt extcon_usb_gpio led_class rtc_omap snd_soc_core snd_pcm_dmae > ngine extcon_palmas ti_soc_thermal dwc3_omap palmas_pwrbutton phy_omap_usb2 tmp102 snd_pcm thermal_sys rtc_palmas snd_ > timer at24 extcon rtc_ds1307 hwmon snd soundcore nvmem_core > [ 53.670141] CPU: 0 PID: 2297 Comm: rtcwake Not tainted 4.6.0-rc1-00004-g7b08b6942309-dirty #6 > [ 53.670141] Hardware name: Generic DRA74X (Flattened Device Tree) > [ 53.670141] task: ed3ab280 ti: ecb28000 task.ti: ecb28000 > [ 53.670141] PC is at omap_set_gpio_triggering+0x44/0x23c > [ 53.670141] LR is at 0xfa059140 > [ 53.670141] pc : [] lr : [] psr: 60070093 > [ 53.670141] sp : ecb29db8 ip : fa059000 fp : c09d3fd4 > [ 53.670141] r10: 60070093 r9 : ee143660 r8 : 60070093 > [ 53.670141] r7 : ee13bc64 r6 : 00000003 r5 : ee13bc10 r4 : 00000000 > [ 53.670141] r3 : c10821cc r2 : 00000003 r1 : 00200000 r0 : ee13bc10 > [ 53.670141] Flags: nZCv IRQs off FIQs on Mode SVC_32 ISA ARM Segment none > [ 53.670141] Control: 10c5387d Table: acd3006a DAC: 00000051 > [ 53.670141] Process rtcwake (pid: 2297, stack limit = 0xecb28218) > [ 53.670141] Stack: (0xecb29db8 to 0xecb2a000) > [ 53.670141] 9da0: 00000015 ee13bc10 > [ 53.670141] 9dc0: 00000003 c04aeb94 ee143600 ee143600 c1043dd0 00000001 c099c354 c01a0b88 > [ 53.670141] 9de0: ee143600 c019ebd8 00000099 c01a4e60 c1044100 c108baf8 c10c6020 c10c20e0 > [ 53.670141] 9e00: c10029cc c10c169f c09d3fa8 c0514840 c100409c 00000003 c1851644 00000000 > [ 53.670141] 9e20: c1851628 00000000 00000000 c10c20e0 00000000 c01981cc c1851650 00000000 > [ 53.670141] 9e40: c099b204 ecb29f88 0000000c c019bd04 c099b1c8 ecb29e74 c10029cc 00000003 > [ 53.670141] 9e60: c10029cc c10c20e0 c1851650 00000000 c099b204 ecb29f88 0000000c c0198a60 > [ 53.670141] 9e80: 0000006d 00000003 c0995434 00000003 c1851654 00000004 ecaddc80 ecb29f88 > [ 53.670141] 9ea0: 00000051 c0196bec ecb13500 00000000 00000004 ecaddc80 00000000 00000000 > [ 53.670141] 9ec0: ecb29f88 c0307944 00000000 00000000 00000001 ecb1350c ecb28000 ecc5d280 > [ 53.670141] 9ee0: c0307884 b6f8f000 ecb29f88 c01079e4 ecb28000 00000000 bedaab3b c028acb0 > [ 53.670141] 9f00: 00000003 00000000 bedaae72 ee6f023c ee6f023c 00000001 00000000 c018abc0 > [ 53.670141] 9f20: ee6f023c 00000001 00000000 c018ac5c 00000001 00000000 c028ec60 c028b940 > [ 53.670141] 9f40: 00001000 00000001 00000004 ecc5d280 00000004 b6f8f000 ecb29f88 c01079e4 > [ 53.670141] 9f60: ecb28000 c028bba0 b6f8f000 c024c784 ecc5d280 ecc5d280 b6f8f000 00000004 > [ 53.670141] 9f80: c01079e4 c028c8c0 00000000 00000000 000277b8 00000004 b6f8f000 000277b8 > [ 53.670141] 9fa0: 00000004 c0107840 00000004 b6f8f000 00000004 b6f8f000 00000004 00000000 > [ 53.670141] 9fc0: 00000004 b6f8f000 000277b8 00000004 00000004 00000000 bedaae65 bedaab3b > [ 53.670141] 9fe0: 00000000 bedaaa3c b6ebac85 b6ef6026 400d0030 00000004 00000000 00000000 > [ 53.670141] [] (omap_set_gpio_triggering) from [] (omap_gpio_unmask_irq+0xc0/0xc4) > [ 53.670141] [] (omap_gpio_unmask_irq) from [] (irq_enable+0x30/0x44) > [ 53.670141] [] (irq_enable) from [] (__enable_irq+0x54/0x78) > [ 53.670141] [] (__enable_irq) from [] (resume_irqs+0xe8/0x100) > [ 53.670141] [] (resume_irqs) from [] (syscore_resume+0x94/0x298) > [ 53.670141] [] (syscore_resume) from [] (suspend_devices_and_enter+0x790/0x9e4) > [ 53.670141] [] (suspend_devices_and_enter) from [] (pm_suspend+0x640/0x75c) > [ 53.670141] [] (pm_suspend) from [] (state_store+0x64/0xb8) > [ 53.670141] [] (state_store) from [] (kernfs_fop_write+0xc0/0x1bc) > [ 53.670141] [] (kernfs_fop_write) from [] (__vfs_write+0x1c/0xd8) > [ 53.670141] [] (__vfs_write) from [] (vfs_write+0x90/0x16c) > [ 53.670141] [] (vfs_write) from [] (SyS_write+0x44/0x9c) > [ 53.670141] [] (SyS_write) from [] (ret_fast_syscall+0x0/0x1c) > [ 53.670141] Code: e3120008 11814004 01c44001 e58e4000 (e1d342b6) > > Fixes: ae64e42cc2b3 ("extcon: palmas: Drop IRQF_EARLY_RESUME flag") > Cc: Grygorii Strashko > Cc: MyungJoo Ham > Cc: Chanwoo Choi > Cc: Tony Lindgren > Cc: Lee Jones > Cc: Roger Quadros > > Signed-off-by: Nishanth Menon > --- > drivers/extcon/extcon-palmas.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/extcon/extcon-palmas.c b/drivers/extcon/extcon-palmas.c > index 841a4b586395..8b3226dca1d9 100644 > --- a/drivers/extcon/extcon-palmas.c > +++ b/drivers/extcon/extcon-palmas.c > @@ -348,8 +348,7 @@ static int palmas_usb_probe(struct platform_device *pdev) > palmas_vbus_irq_handler, > IRQF_TRIGGER_FALLING | > IRQF_TRIGGER_RISING | > - IRQF_ONESHOT | > - IRQF_EARLY_RESUME, > + IRQF_ONESHOT, > "palmas_usb_vbus", > palmas_usb); > if (status < 0) { >