From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758891AbcDAIRs (ORCPT ); Fri, 1 Apr 2016 04:17:48 -0400 Received: from mailout1.w1.samsung.com ([210.118.77.11]:54119 "EHLO mailout1.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754466AbcDAIRZ (ORCPT ); Fri, 1 Apr 2016 04:17:25 -0400 X-AuditID: cbfec7f4-f796c6d000001486-a3-56fe2e9148d9 Subject: Re: [PATCH 04/11] ARM: dts: exynos: Fix DTC unit name warnings in Trats2 board To: Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Kukjin Kim , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org References: <1459493874-2366-1-git-send-email-k.kozlowski@samsung.com> <1459493874-2366-4-git-send-email-k.kozlowski@samsung.com> From: Krzysztof Kozlowski Message-id: <56FE2E8C.3060107@samsung.com> Date: Fri, 01 Apr 2016 17:17:16 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-version: 1.0 In-reply-to: <1459493874-2366-4-git-send-email-k.kozlowski@samsung.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrDLMWRmVeSWpSXmKPExsVy+t/xK7oT9f6FGby7r20x/8g5Vov+NwtZ Lc69Wslo8fqFoUX/49fMFpseX2O1uLxrDpvFjPP7mCyWXr/IZDFh+loWi9a9R9gduD3WzFvD 6HG5r5fJY+XyL2wem1Z1snlsXlLv0bdlFaPH501yAexRXDYpqTmZZalF+nYJXBlL7t9lLpjH UzH7/1+mBsaFXF2MnBwSAiYSf2bdYoWwxSQu3FvP1sXIxSEksJRRYte/n1DOU0aJ/vkrwaqE BSIlTl19wAiSEBF4ziSx6tsiFoiqZkaJY3t2MYNUsQkYS2xevoQNxOYV0JKY1H4MrJtFQFVi 6YJX7CC2qECExJO5JxkhagQlfky+xwJicwq4S2xZfhNoDgcHs4CexP2LWiBhZgF5ic1r3jJP YOSfhaRjFkLVLCRVCxiZVzGKppYmFxQnpeca6hUn5haX5qXrJefnbmKExMGXHYyLj1kdYhTg YFTi4b0x7W+YEGtiWXFl7iFGCQ5mJRHeGp1/YUK8KYmVValF+fFFpTmpxYcYpTlYlMR55+56 HyIkkJ5YkpqdmlqQWgSTZeLglGpgbHt8ZBOLH2PvU767Zw//2aS7I6pF5XbOnrOBESHXYk23 f/9lN+ld1C7eZMn6PZ8etHv9eXrgYPF82yNLPZZvfTL7ShZTcl6BSabaJy7hnFKmp67rMl4E /Tuor2RV47yNuXZpzpl4RSXvlW/4y8tmqmXu+PdT2K1FgUfwgu7Dw7e5d8bsbj8QosRSnJFo qMVcVJwIAMrkH4R/AgAA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01.04.2016 15:57, Krzysztof Kozlowski wrote: > Fix following DTC warnings in Trats2 board: > > Warning (unit_address_vs_reg): Node /memory has a reg or ranges property, but no unit name > Warning (unit_address_vs_reg): Node /i2c-gpio-1/max77693@66/regulators/ESAFEOUT1@1 has a unit name, but no reg property > Warning (unit_address_vs_reg): Node /i2c-gpio-1/max77693@66/regulators/ESAFEOUT2@2 has a unit name, but no reg property > Warning (unit_address_vs_reg): Node /i2c-gpio-1/max77693@66/regulators/CHARGER@0 has a unit name, but no reg property > Warning (unit_address_vs_reg): Node /thermistor-ap@0 has a unit name, but no reg property > Warning (unit_address_vs_reg): Node /thermistor-battery@1 has a unit name, but no reg property > > Signed-off-by: Krzysztof Kozlowski > --- > arch/arm/boot/dts/exynos4412-trats2.dts | 14 +++++++------- > 1 file changed, 7 insertions(+), 7 deletions(-) > > diff --git a/arch/arm/boot/dts/exynos4412-trats2.dts b/arch/arm/boot/dts/exynos4412-trats2.dts > index 2bf363c3bf62..523627003738 100644 > --- a/arch/arm/boot/dts/exynos4412-trats2.dts > +++ b/arch/arm/boot/dts/exynos4412-trats2.dts > @@ -29,7 +29,7 @@ > i2c12 = &i2c_max77693_fuel; > }; > > - memory { > + mmemory@40000000 { > reg = <0x40000000 0x40000000>; > }; Nope, beside obvious typo here, this is bad. This causes creation of duplicated memory nodes, one coming from skeleton and one from here. Rob, How the 'memory' node warning should be fixed? Best regards, Krzysztof