Re: [Xen-devel] [PATCH v7 11/17] ARM: XEN: Move xen_early_init() before efi_init()

Stefano Stabellini
2016-03-31T11:14:14Z

On Tue, 29 Mar 2016, Will Deacon wrote:
> On Sat, Mar 26, 2016 at 12:54:09PM +0000, Stefano Stabellini wrote:
> > are you OK with this patch?
>
> Nothing against it, but the only arm64 bit is:
>
> > > diff --git a/arch/arm64/kernel/setup.c b/arch/arm64/kernel/setup.c
> > > index 450987d..6cf5051 100644
> > > --- a/arch/arm64/kernel/setup.c
> > > +++ b/arch/arm64/kernel/setup.c
> > > @@ -313,6 +313,7 @@ void __init setup_arch(char **cmdline_p)
> > > */
> > > local_async_enable();
> > >
> > > + xen_early_init();
> > > efi_init();
> > > arm64_memblock_init();
> > >
> > > @@ -334,7 +335,6 @@ void __init setup_arch(char **cmdline_p)
> > > } else {
> > > psci_acpi_init();
> > > }
> > > - xen_early_init();
>
> so it's difficult to care too much ;)

Understood :-)

> I do hope that there won't be a
> need to split up efi_init() in future because some of it has to happen
> before xen_early_init, but that doesn't sound likely at the moment.

Right.

The series is almost fully acked, if you are OK with it, as soon as the
last couple of remaining comments are resolved, I'll queue it up in the
xentip tree for 4.7 (now it is too late for 4.6).