From: Mathias Nyman <mathias.nyman@linux.intel.com>
To: Rajesh Bhagat <rajesh.bhagat@nxp.com>
Cc: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Sriram Dash <sriram.dash@nxp.com>
Subject: Re: [PATCH] usb: xhci: Fix incomplete PM resume operation due to XHCI commmand timeout
Date: Fri, 01 Apr 2016 13:49:53 +0300 [thread overview]
Message-ID: <56FE5251.5020806@linux.intel.com> (raw)
In-Reply-To: <HE1PR0401MB2028787DE01C0C8E79520414E39A0@HE1PR0401MB2028.eurprd04.prod.outlook.com>
On 01.04.2016 06:55, Rajesh Bhagat wrote:
>>>
>>> Please share your opinion on other changes for patch submission as well as resume
>> time.
>>>
>
>>
>> I think more effort should be put into investigating why this happens in the first place.
>> What is the root cause? why doesn't xhci start properly after resume in this case.
>>
> Hello Mathias,
>
> I understand your point and would surely debug the root cause of the issue. But implementing the
> fallback mechanism in SW, if HW does not respond well seems to a better solution to me.
>
Yes, I'll add something like this, at least the xhci parts to make sure the completions are called.
This is not really a fallback, it's just a better burial for xhci. It will be unusable after this.
-Mathias
next prev parent reply other threads:[~2016-04-01 10:43 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-18 7:01 [PATCH] usb: xhci: Fix incomplete PM resume operation due to XHCI commmand timeout Rajesh Bhagat
2016-03-18 11:20 ` Mathias Nyman
2016-03-21 4:18 ` Rajesh Bhagat
2016-03-21 9:16 ` Mathias Nyman
2016-03-22 5:19 ` Rajesh Bhagat
2016-03-22 12:05 ` Mathias Nyman
2016-03-23 3:53 ` Rajesh Bhagat
2016-03-23 14:22 ` Mathias Nyman
2016-03-28 6:13 ` Rajesh Bhagat
2016-03-29 17:21 ` Mathias Nyman
2016-03-31 3:51 ` Rajesh Bhagat
2016-03-31 14:36 ` Mathias Nyman
2016-04-01 3:55 ` Rajesh Bhagat
2016-04-01 10:49 ` Mathias Nyman [this message]
2016-04-11 3:46 ` Rajesh Bhagat
2016-03-18 14:21 ` Alan Stern
2016-03-21 4:22 ` Rajesh Bhagat
2016-03-21 15:02 ` Alan Stern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56FE5251.5020806@linux.intel.com \
--to=mathias.nyman@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=rajesh.bhagat@nxp.com \
--cc=sriram.dash@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox