From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S932419AbcDAK6m (ORCPT <rfc822;w@1wt.eu>);
	Fri, 1 Apr 2016 06:58:42 -0400
Received: from mail-lf0-f47.google.com ([209.85.215.47]:33893 "EHLO
	mail-lf0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1759205AbcDAK6j (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 1 Apr 2016 06:58:39 -0400
Subject: Re: [PATCH v3 3/3] perf tools: Hook up MIPS unwind and dwarf-regs in
 the Makefile
To: Ralf Baechle <ralf@linux-mips.org>, Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>,
        Arnaldo Carvalho de Melo <acme@kernel.org>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        David Daney <david.daney@cavium.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Paul Burton <paul.burton@imgtec.com>,
        James Hogan <james.hogan@imgtec.com>,
        Matt Redfearn <matt.redfearn@imgtec.com>,
        Qais Yousef <qais.yousef@imgtec.com>,
        Ben Hutchings <ben@decadent.org.uk>, Jiri Olsa <jolsa@redhat.com>,
        Wang Nan <wangnan0@huawei.com>,
        Adrian Hunter <adrian.hunter@intel.com>,
        Namhyung Kim <namhyung@kernel.org>,
        Stephane Eranian <eranian@google.com>, linux-mips@linux-mips.org,
        linux-kernel@vger.kernel.org
References: <cover.1459501014.git.ralf@linux-mips.org>
 <a3a7e99203ceaf662dc61895418c76e837eaf6ab.1459501014.git.ralf@linux-mips.org>
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Message-ID: <56FE545A.7090003@cogentembedded.com>
Date: Fri, 1 Apr 2016 13:58:34 +0300
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101
 Thunderbird/38.7.1
MIME-Version: 1.0
In-Reply-To: <a3a7e99203ceaf662dc61895418c76e837eaf6ab.1459501014.git.ralf@linux-mips.org>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hello.

On 4/1/2016 11:56 AM, Ralf Baechle wrote:

> From: David Daney <david.daney@cavium.com>
>
> Define a new symbol (ARCH_SUPPORTS_LIBUNWIND) in config/Makefile.

    Eh? Where is it?

> Use this from x86 and MIPS to gate testing of libunwind.

    x86? Where?

> Signed-off-by: David Daney <david.daney@cavium.com>
> Cc: linux-mips@linux-mips.org
> Cc: Jiri Olsa <jolsa@redhat.com>
> Cc: linux-kernel@vger.kernel.org
> Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
> Cc: Paul Mackerras <paulus@samba.org>
> Cc: Ingo Molnar <mingo@redhat.com>
> Cc: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
> Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
> ---
>   tools/perf/config/Makefile | 5 +++++
>   1 file changed, 5 insertions(+)
>
> diff --git a/tools/perf/config/Makefile b/tools/perf/config/Makefile
> index f7d7f5a..713c69c 100644
> --- a/tools/perf/config/Makefile
> +++ b/tools/perf/config/Makefile
> @@ -51,6 +51,11 @@ ifeq ($(NO_PERF_REGS),0)
>     $(call detected,CONFIG_PERF_REGS)
>   endif
>
> +ifeq ($(ARCH),mips)
> +  NO_PERF_REGS := 0
> +  LIBUNWIND_LIBS = -lunwind -lunwind-mips
> +endif
> +
>   # So far there's only x86 and arm libdw unwind support merged in perf.
>   # Disable it on all other architectures in case libdw unwind
>   # support is detected in system. Add supported architectures

MBR, Sergei