From: Adrian Hunter <adrian.hunter@intel.com>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: He Kuang <hekuang@huawei.com>,
peterz@infradead.org, Ingo Molnar <mingo@kernel.org>,
alexander.shishkin@linux.intel.com, Jiri Olsa <jolsa@kernel.org>,
jpoimboe@redhat.com, sukadev@linux.vnet.ibm.com,
eranian@google.com, wangnan0@huawei.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] perf tools: Fix build errors on tsc functions for archs other than x86
Date: Fri, 1 Apr 2016 16:39:15 +0300 [thread overview]
Message-ID: <56FE7A03.4060608@intel.com> (raw)
In-Reply-To: <20160401132406.GC7115@kernel.org>
On 01/04/16 16:24, Arnaldo Carvalho de Melo wrote:
> Em Fri, Apr 01, 2016 at 10:13:12AM -0300, Arnaldo Carvalho de Melo escreveu:
>> Em Fri, Apr 01, 2016 at 03:49:32AM +0000, He Kuang escreveu:
>>> Build errors on aarch64:
>>>
>>> libperf.a(libperf-in.o): In function `convert_timestamp':
>>> util/jitdump.c:356: undefined reference to `tsc_to_perf_time'
>>> collect2: error: ld returned 1 exit status
>>> Makefile.perf:347: recipe for target 'perf' failed
>>> make[1]: *** [perf] Error 1
>>> Makefile:68: recipe for target 'all' failed
>>> make: *** [all] Error 2
>>
>> Got it, my cross-compile environment for aarch64 doesn't build jitdump.c
>> because it needs a package I haven't found in ubuntu:
>>
>> config/Makefile:416: No libcrypto.h found, disables jitted code injection, please install libssl-devel or libssl-dev
>> minimal-ubuntu-x-arm64: Ok
>>
>> BTW, He, what environment do you use to build for arm64, is it a cross
>> compile one? Yocto?
>
> Adrian, BTW, Ok with this? I'm adding a:
>
> Fixes: d3e58a3b8b3b ("perf jit: Add support for using TSC as a timestamp")
>
> And would appreciate your Acked-by.
Sure, already did in http://marc.info/?l=linux-kernel&m=145949505329251
Acked-by: Adrian Hunter <adrian.hunter@intel.com>
next prev parent reply other threads:[~2016-04-01 13:43 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-03 11:50 [PATCH 0/8] perf tools: Add Intel PT support for jitdump Adrian Hunter
2016-03-03 11:50 ` [PATCH 1/8] perf inject: Hit all DSOs for AUX data in JIT and other cases Adrian Hunter
2016-03-08 10:30 ` [tip:perf/core] " tip-bot for Adrian Hunter
2016-03-03 11:50 ` [PATCH 2/8] perf session: Simplify tool stubs Adrian Hunter
2016-03-08 8:38 ` [PATCH V2 " Adrian Hunter
2016-03-08 10:30 ` [tip:perf/core] " tip-bot for Adrian Hunter
2016-03-03 11:50 ` [PATCH 3/8] perf tools: Add time conversion event Adrian Hunter
2016-03-08 8:38 ` [PATCH V2 " Adrian Hunter
2016-03-31 6:33 ` Adrian Hunter
2016-03-31 13:53 ` Arnaldo Carvalho de Melo
2016-04-06 7:07 ` [tip:perf/core] " tip-bot for Adrian Hunter
2016-03-03 11:50 ` [PATCH 4/8] perf jit: Let jit_process() return errors Adrian Hunter
2016-03-08 10:30 ` [tip:perf/core] " tip-bot for Adrian Hunter
2016-03-03 11:50 ` [PATCH 5/8] perf jit: Move clockid validation Adrian Hunter
2016-03-08 8:38 ` [PATCH V2 " Adrian Hunter
2016-03-08 10:31 ` [tip:perf/core] " tip-bot for Adrian Hunter
2016-03-03 11:50 ` [PATCH 6/8] perf jit: Add support for using TSC as a timestamp Adrian Hunter
2016-03-08 8:38 ` [PATCH V2 " Adrian Hunter
2016-04-01 3:49 ` [PATCH] perf tools: Fix build errors on tsc functions for archs other than x86 He Kuang
2016-04-01 7:13 ` Adrian Hunter
2016-04-01 13:13 ` Arnaldo Carvalho de Melo
2016-04-01 13:19 ` Hekuang
2016-04-01 13:24 ` Arnaldo Carvalho de Melo
2016-04-01 13:39 ` Adrian Hunter [this message]
2016-04-06 7:08 ` [tip:perf/core] perf jit: Add support for using TSC as a timestamp tip-bot for Adrian Hunter
2016-03-03 11:50 ` [PATCH 7/8] perf intel-pt/bts: Define JITDUMP_USE_ARCH_TIMESTAMP Adrian Hunter
2016-03-08 8:38 ` [PATCH V2 " Adrian Hunter
2016-04-06 7:08 ` [tip:perf/core] " tip-bot for Adrian Hunter
2016-03-03 11:50 ` [PATCH 8/8] perf tools: Use 64-bit shifts with (TSC) time conversion Adrian Hunter
2016-03-08 10:31 ` [tip:perf/core] " tip-bot for Adrian Hunter
2016-03-08 8:49 ` [PATCH 0/8] perf tools: Add Intel PT support for jitdump Adrian Hunter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56FE7A03.4060608@intel.com \
--to=adrian.hunter@intel.com \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=eranian@google.com \
--cc=hekuang@huawei.com \
--cc=jolsa@kernel.org \
--cc=jpoimboe@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=sukadev@linux.vnet.ibm.com \
--cc=wangnan0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).