From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758660AbcDANnP (ORCPT ); Fri, 1 Apr 2016 09:43:15 -0400 Received: from mga04.intel.com ([192.55.52.120]:2897 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753517AbcDANnO (ORCPT ); Fri, 1 Apr 2016 09:43:14 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,427,1455004800"; d="scan'208";a="946063621" Subject: Re: [PATCH] perf tools: Fix build errors on tsc functions for archs other than x86 To: Arnaldo Carvalho de Melo References: <1459482572-129494-1-git-send-email-hekuang@huawei.com> <20160401131312.GB7115@kernel.org> <20160401132406.GC7115@kernel.org> Cc: He Kuang , peterz@infradead.org, Ingo Molnar , alexander.shishkin@linux.intel.com, Jiri Olsa , jpoimboe@redhat.com, sukadev@linux.vnet.ibm.com, eranian@google.com, wangnan0@huawei.com, linux-kernel@vger.kernel.org From: Adrian Hunter Organization: Intel Finland Oy, Registered Address: PL 281, 00181 Helsinki, Business Identity Code: 0357606 - 4, Domiciled in Helsinki Message-ID: <56FE7A03.4060608@intel.com> Date: Fri, 1 Apr 2016 16:39:15 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <20160401132406.GC7115@kernel.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/04/16 16:24, Arnaldo Carvalho de Melo wrote: > Em Fri, Apr 01, 2016 at 10:13:12AM -0300, Arnaldo Carvalho de Melo escreveu: >> Em Fri, Apr 01, 2016 at 03:49:32AM +0000, He Kuang escreveu: >>> Build errors on aarch64: >>> >>> libperf.a(libperf-in.o): In function `convert_timestamp': >>> util/jitdump.c:356: undefined reference to `tsc_to_perf_time' >>> collect2: error: ld returned 1 exit status >>> Makefile.perf:347: recipe for target 'perf' failed >>> make[1]: *** [perf] Error 1 >>> Makefile:68: recipe for target 'all' failed >>> make: *** [all] Error 2 >> >> Got it, my cross-compile environment for aarch64 doesn't build jitdump.c >> because it needs a package I haven't found in ubuntu: >> >> config/Makefile:416: No libcrypto.h found, disables jitted code injection, please install libssl-devel or libssl-dev >> minimal-ubuntu-x-arm64: Ok >> >> BTW, He, what environment do you use to build for arm64, is it a cross >> compile one? Yocto? > > Adrian, BTW, Ok with this? I'm adding a: > > Fixes: d3e58a3b8b3b ("perf jit: Add support for using TSC as a timestamp") > > And would appreciate your Acked-by. Sure, already did in http://marc.info/?l=linux-kernel&m=145949505329251 Acked-by: Adrian Hunter