From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759200AbcDAOf4 (ORCPT ); Fri, 1 Apr 2016 10:35:56 -0400 Received: from lists.s-osg.org ([54.187.51.154]:60069 "EHLO lists.s-osg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758836AbcDAOfy (ORCPT ); Fri, 1 Apr 2016 10:35:54 -0400 Subject: Re: [PATCH 04/11] ARM: dts: exynos: Fix DTC unit name warnings in Trats2 board To: Krzysztof Kozlowski , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Kukjin Kim , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org References: <1459493874-2366-1-git-send-email-k.kozlowski@samsung.com> <1459493874-2366-4-git-send-email-k.kozlowski@samsung.com> From: Javier Martinez Canillas Message-ID: <56FE873C.2090503@osg.samsung.com> Date: Fri, 1 Apr 2016 10:35:40 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <1459493874-2366-4-git-send-email-k.kozlowski@samsung.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Krzysztof, On 04/01/2016 02:57 AM, Krzysztof Kozlowski wrote: > Fix following DTC warnings in Trats2 board: > > Warning (unit_address_vs_reg): Node /memory has a reg or ranges property, but no unit name > Warning (unit_address_vs_reg): Node /i2c-gpio-1/max77693@66/regulators/ESAFEOUT1@1 has a unit name, but no reg property > Warning (unit_address_vs_reg): Node /i2c-gpio-1/max77693@66/regulators/ESAFEOUT2@2 has a unit name, but no reg property > Warning (unit_address_vs_reg): Node /i2c-gpio-1/max77693@66/regulators/CHARGER@0 has a unit name, but no reg property > Warning (unit_address_vs_reg): Node /thermistor-ap@0 has a unit name, but no reg property > Warning (unit_address_vs_reg): Node /thermistor-battery@1 has a unit name, but no reg property > > Signed-off-by: Krzysztof Kozlowski > --- > arch/arm/boot/dts/exynos4412-trats2.dts | 14 +++++++------- > 1 file changed, 7 insertions(+), 7 deletions(-) > > diff --git a/arch/arm/boot/dts/exynos4412-trats2.dts b/arch/arm/boot/dts/exynos4412-trats2.dts > index 2bf363c3bf62..523627003738 100644 > --- a/arch/arm/boot/dts/exynos4412-trats2.dts > +++ b/arch/arm/boot/dts/exynos4412-trats2.dts > @@ -29,7 +29,7 @@ > i2c12 = &i2c_max77693_fuel; > }; > > - memory { > + mmemory@40000000 { > reg = <0x40000000 0x40000000>; > }; > Besides this creating duplicated memory nodes as you said, plain memory should be allowed according to Rob and he plans to add an exception to dtc: http://www.spinics.net/lists/arm-kernel/msg494038.html Rest of the patch looks good so after removing the memory node change: Reviewed-by: Javier Martinez Canillas Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America