From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754124AbcDAOpu (ORCPT ); Fri, 1 Apr 2016 10:45:50 -0400 Received: from comal.ext.ti.com ([198.47.26.152]:39373 "EHLO comal.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752360AbcDAOpt (ORCPT ); Fri, 1 Apr 2016 10:45:49 -0400 Subject: Re: [PATCH V2] extcon: palmas: Drop stray IRQF_EARLY_RESUME flag To: Nishanth Menon , Chanwoo Choi , MyungJoo Ham References: <1459518767-20382-1-git-send-email-nm@ti.com> CC: , , , Grygorii Strashko , Tony Lindgren , Lee Jones From: Roger Quadros Message-ID: <56FE897D.3040107@ti.com> Date: Fri, 1 Apr 2016 17:45:17 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <1459518767-20382-1-git-send-email-nm@ti.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/04/16 16:52, Nishanth Menon wrote: > Palmas extcon IRQs are nested threaded and wired to the Palmas > interrupt controller. So, this flag is not required for nested > IRQs anymore, since commit 3c646f2c6aa9 ("genirq: Don't suspend > nested_thread irqs over system suspend") was merged. However, the > fix in commit ae64e42cc2b3 ("extcon: palmas: Drop IRQF_EARLY_RESUME > flag") missed a stray flag causing the following crash on resume on > BeagleBoard-X15 platform: > > [ 53.670141] Unhandled fault: imprecise external abort (0x1406) at 0x00000000 > [..] > [ 53.670141] [] (omap_set_gpio_triggering) from [] (omap_gpio_unmask_irq+0xc0/0xc4) > [ 53.670141] [] (omap_gpio_unmask_irq) from [] (irq_enable+0x30/0x44) > [ 53.670141] [] (irq_enable) from [] (__enable_irq+0x54/0x78) > [ 53.670141] [] (__enable_irq) from [] (resume_irqs+0xe8/0x100) > [ 53.670141] [] (resume_irqs) from [] (syscore_resume+0x94/0x298) > [ 53.670141] [] (syscore_resume) from [] (suspend_devices_and_enter+0x790/0x9e4) > [ 53.670141] [] (suspend_devices_and_enter) from [] (pm_suspend+0x640/0x75c) > [ 53.670141] [] (pm_suspend) from [] (state_store+0x64/0xb8) > [ 53.670141] [] (state_store) from [] (kernfs_fop_write+0xc0/0x1bc) > [ 53.670141] [] (kernfs_fop_write) from [] (__vfs_write+0x1c/0xd8) > [ 53.670141] [] (__vfs_write) from [] (vfs_write+0x90/0x16c) > [ 53.670141] [] (vfs_write) from [] (SyS_write+0x44/0x9c) > [ 53.670141] [] (SyS_write) from [] (ret_fast_syscall+0x0/0x1c) > [..] > > Fixes: ae64e42cc2b3 ("extcon: palmas: Drop IRQF_EARLY_RESUME flag") > Cc: Grygorii Strashko > Cc: MyungJoo Ham > Cc: Chanwoo Choi > Cc: Tony Lindgren > Cc: Lee Jones > Cc: Roger Quadros > > Reviewed-by: Grygorii Strashko > Signed-off-by: Nishanth Menon Acked-by: Roger Quadros cheers, -roger > --- > based on v4.6-rc1 > Changes in V2: > - commit message updates for: > - Trimming the crash log down to base stack trace > - Fix up a few typos > - Update commit log to indicate that this is a completion of > previously attempted fix . > > V1: https://patchwork.kernel.org/patch/8718431/ > > drivers/extcon/extcon-palmas.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/extcon/extcon-palmas.c b/drivers/extcon/extcon-palmas.c > index 841a4b586395..8b3226dca1d9 100644 > --- a/drivers/extcon/extcon-palmas.c > +++ b/drivers/extcon/extcon-palmas.c > @@ -348,8 +348,7 @@ static int palmas_usb_probe(struct platform_device *pdev) > palmas_vbus_irq_handler, > IRQF_TRIGGER_FALLING | > IRQF_TRIGGER_RISING | > - IRQF_ONESHOT | > - IRQF_EARLY_RESUME, > + IRQF_ONESHOT, > "palmas_usb_vbus", > palmas_usb); > if (status < 0) { >