From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Stefan Agner <stefan@agner.ch>, arnd@arndb.de
Cc: mark.rutland@arm.com, devicetree@vger.kernel.org,
mcoquelin.stm32@gmail.com, pawel.moll@arm.com,
ijc+devicetree@hellion.org.uk, galak@codeaurora.org,
linux-kernel@vger.kernel.org, robh+dt@kernel.org,
kernel@pengutronix.de, u.kleine-koenig@pengutronix.de,
shawnguo@kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ARM: dts: armv7-m: add address to unit name
Date: Sat, 2 Apr 2016 19:12:30 +0300 [thread overview]
Message-ID: <56FFEF6E.2000002@cogentembedded.com> (raw)
In-Reply-To: <1459577299-2818-1-git-send-email-stefan@agner.ch>
Hello.
On 4/2/2016 9:08 AM, Stefan Agner wrote:
> Add address to unit name to remove the following warning:
> Warning (unit_address_vs_reg): Node /nv-interrupt-controller has a
> reg or ranges property, but no unit name
>
> Signed-off-by: Stefan Agner <stefan@agner.ch>
> ---
> Hi Arnd,
>
> Not sure through which tree this should go but an earlier patch
> seemd to be applied directly by you...
>
> --
> Stefan
>
> arch/arm/boot/dts/armv7-m.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/armv7-m.dtsi b/arch/arm/boot/dts/armv7-m.dtsi
> index b1ad7cf..8126bec 100644
> --- a/arch/arm/boot/dts/armv7-m.dtsi
> +++ b/arch/arm/boot/dts/armv7-m.dtsi
> @@ -1,7 +1,7 @@
> #include "skeleton.dtsi"
>
> / {
> - nvic: nv-interrupt-controller {
> + nvic: nv-interrupt-controller@0xe000e100 {
Drop "0x" from <unit address> please. And the name should be just
"interrupt-controller@..."
WBR, Sergei
prev parent reply other threads:[~2016-04-02 16:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-02 6:08 [PATCH] ARM: dts: armv7-m: add address to unit name Stefan Agner
2016-04-02 13:41 ` Joachim Eastwood
2016-04-02 16:12 ` Sergei Shtylyov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56FFEF6E.2000002@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=arnd@arndb.de \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=shawnguo@kernel.org \
--cc=stefan@agner.ch \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox