From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9E4DEECAAD8 for ; Wed, 14 Sep 2022 03:02:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229673AbiINDCd (ORCPT ); Tue, 13 Sep 2022 23:02:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38910 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229598AbiINDC2 (ORCPT ); Tue, 13 Sep 2022 23:02:28 -0400 Received: from out30-130.freemail.mail.aliyun.com (out30-130.freemail.mail.aliyun.com [115.124.30.130]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 51FCB6BD60; Tue, 13 Sep 2022 20:02:26 -0700 (PDT) X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R131e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018046050;MF=jefflexu@linux.alibaba.com;NM=1;PH=DS;RN=8;SR=0;TI=SMTPD_---0VPlAizs_1663124541; Received: from 30.221.129.214(mailfrom:jefflexu@linux.alibaba.com fp:SMTPD_---0VPlAizs_1663124541) by smtp.aliyun-inc.com; Wed, 14 Sep 2022 11:02:22 +0800 Message-ID: <56b0a8c1-94ce-3219-6b43-d91d2e0e85b5@linux.alibaba.com> Date: Wed, 14 Sep 2022 11:02:21 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.13.0 Subject: Re: [PATCH V2 2/5] erofs: introduce fscache-based domain Content-Language: en-US To: Jia Zhu , linux-erofs@lists.ozlabs.org, xiang@kernel.org, chao@kernel.org Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, yinxin.x@bytedance.com, huyue2@coolpad.com References: <20220902105305.79687-1-zhujia.zj@bytedance.com> <20220902105305.79687-3-zhujia.zj@bytedance.com> From: JeffleXu In-Reply-To: <20220902105305.79687-3-zhujia.zj@bytedance.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 9/2/22 6:53 PM, Jia Zhu wrote: > int erofs_fscache_register_cookie(struct super_block *sb, > struct erofs_fscache **fscache, > char *name, bool need_inode) > @@ -495,7 +581,8 @@ int erofs_fscache_register_fs(struct super_block *sb) > char *name; > int ret = 0; > > - name = kasprintf(GFP_KERNEL, "erofs,%s", sbi->opt.fsid); > + name = kasprintf(GFP_KERNEL, "erofs,%s", > + sbi->domain ? sbi->domain->domain_id : sbi->opt.fsid); > if (!name) > return -ENOMEM; > What if domain_id and fsid has the same value? How about the format "erofs,,"? While in the non-share-domain mode, is the format like "erofs,," or the default "erofs,"? -- Thanks, Jingbo