From: Chao Yu <chao@kernel.org>
To: Jaegeuk Kim <jaegeuk@kernel.org>,
linux-kernel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net
Cc: Al Viro <viro@zeniv.linux.org.uk>
Subject: Re: [f2fs-dev] [PATCH] f2fs: remove unnecessary f2fs_put_page in f2fs_rename
Date: Sat, 13 Jan 2024 10:24:35 +0800 [thread overview]
Message-ID: <56bdcf95-2b15-4f5b-9146-e9b37bd5b62a@kernel.org> (raw)
In-Reply-To: <20240112171645.3929428-1-jaegeuk@kernel.org>
On 2024/1/13 1:16, Jaegeuk Kim wrote:
> [1] changed the below condition, which made f2fs_put_page() voided.
> This patch reapplies the AL's resolution in -next from [2].
>
> - if (S_ISDIR(old_inode->i_mode)) {
> + if (old_is_dir && old_dir != new_dir) {
> old_dir_entry = f2fs_parent_dir(old_inode, &old_dir_page);
> if (!old_dir_entry) {
> if (IS_ERR(old_dir_page))
>
> [1] 7deee77b993a ("f2fs: Avoid reading renamed directory if parent does not change")
> [2] https://lore.kernel.org/all/20231220013402.GW1674809@ZenIV/
>
> Suggested-by: Al Viro <viro@zeniv.linux.org.uk>
> Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
Reviewed-by: Chao Yu <chao@kernel.org>
Thanks,
next prev parent reply other threads:[~2024-01-13 2:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-12 17:16 [PATCH] f2fs: remove unnecessary f2fs_put_page in f2fs_rename Jaegeuk Kim
2024-01-13 2:24 ` Chao Yu [this message]
2024-01-29 20:29 ` [f2fs-dev] " patchwork-bot+f2fs
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56bdcf95-2b15-4f5b-9146-e9b37bd5b62a@kernel.org \
--to=chao@kernel.org \
--cc=jaegeuk@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox