From: Baolu Lu <baolu.lu@linux.intel.com>
To: Qihang <q.h.hack.winter@gmail.com>,
Joerg Roedel <joro@8bytes.org>, Will Deacon <will@kernel.org>,
Jason Gunthorpe <jgg@nvidia.com>
Cc: baolu.lu@linux.intel.com, Robin Murphy <robin.murphy@arm.com>,
iommu@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/2] iommu/io-pgfault: reject partial faults after device removal
Date: Fri, 20 Nov 2026 15:56:34 +0800 [thread overview]
Message-ID: <56be2b4e-aefb-413b-8f72-0bea1f9e96db@linux.intel.com> (raw)
In-Reply-To: <20261117015409.25492-1-q.h.hack.winter@gmail.com>
On 11/17/2026 9:54 AM, Qihang wrote:
> iopf_queue_remove_device() kfree()s the entries on
> fault_param->partial without unlinking them, leaving the list head
> pointing into freed memory. Since a74c077b9021 the fault parameter is
> refcounted and can outlive the drain, a report that took its reference
> earlier can still list_add() through those pointers. Unlinking
> instead turns that into a leak: the late node lands on a parameter
> that is no longer on queue->devices, whose final put does not free
> partial faults.
>
> This needs a device removed from its iopf queue while a non-last
> (partial) request is in flight, with the caller not blocking new reports
> for the duration.
>
> Patch 1 unlinks each partial before freeing it, matching
> iopf_queue_discard_partial().
>
> Patch 2 adds fault_param->removing, set and tested under
> fault_param->lock: a late partial is either drained, or rejected and
> freed by report_partial_fault() (-ENODEV). It covers partial-list
> admission only; callers must still quiesce reports for the remaining
> lifetimes.
>
> Both patches are scoped to fault_param->partial, not the group path,
> the attach handle, or paths that never call iopf_queue_remove_device().
>
> Verified on v7.4-rc3 with KASAN + DEBUG_LIST and the iommufd mock
> driver, its caller-side IOPF serialization deliberately removed and
> test-only delays added; this shows the mechanism, not production
> reachability. The runs cover queue-before-removal,
> removal-before-insertion, concurrent late reporters and re-enable.
> Each round queues one partial before the removal and then races the
> late reporters against the drain, so a clean run ends with every node
> accounted for: 1800 = 900 + 900 and 3600 = 900 + 2700 (allocated =
> drained + rejected), counted at a final removal with no reporter in
> flight. Nothing was left on fault_param->partial and KASAN stayed
> quiet.
>
> With patch 1 reverted, the report is:
>
> BUG: KASAN: slab-use-after-free in __list_add_valid_or_report
> Freed by task 1: kfree <- iopf_queue_remove_device
> 56 bytes inside a freed 64-byte region (struct iopf_fault, list.prev)
>
> With patch 1 only, the same reproducer runs 1460 rounds without a KASAN
> report and leaks one late node per round, which patch 2 addresses.
>
> Reachability on an unmodified production kernel, and any security
> impact, remain unconfirmed: the test shows memory corruption and a
> KASAN panic on the modified mock driver, not a user-triggerable bug on
> a stock kernel.
>
> An AI coding assistant helped find this defect and build the
> reproducer and instrumentation, which are available on request along
> with the KASAN logs.
+Jason
The issues addressed by both patches are false positives. They rely on a
fault being reported for a device after iopf_queue_remove_device() has
been called for that device. The iommu driver must not allow that.
Pending i/o page faults must be drained before the device is removed
from its iommu's io page fault queue.
Thanks,
baolu
prev parent reply other threads:[~2026-11-20 7:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-17 1:54 [PATCH 0/2] iommu/io-pgfault: reject partial faults after device removal Qihang
2026-11-17 1:54 ` [PATCH 1/2] iommu/io-pgfault: unlink partial faults before freeing them Qihang
2026-11-17 1:54 ` [PATCH 2/2] iommu/io-pgfault: reject partial faults after the device is removed Qihang
2026-11-20 7:56 ` Baolu Lu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56be2b4e-aefb-413b-8f72-0bea1f9e96db@linux.intel.com \
--to=baolu.lu@linux.intel.com \
--cc=iommu@lists.linux.dev \
--cc=jgg@nvidia.com \
--cc=joro@8bytes.org \
--cc=linux-kernel@vger.kernel.org \
--cc=q.h.hack.winter@gmail.com \
--cc=robin.murphy@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox