From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ot1-f68.google.com (mail-ot1-f68.google.com [209.85.210.68]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 87075274FE3 for ; Tue, 23 Dec 2025 18:26:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.68 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766514375; cv=none; b=cGkm3JEeeGoN0lcmPuhuSDLoLgnlBjiJngHqBHULzyHLSn2cbZc0JR0L24ufhPbwO5RFtNaWIyO0CePEJ8bq5HiupwGVJV0TzFMCnLnumewWfrLR1YthxKkZygKABnnalGtNGXVHpp1D9wvNx3O3HmTPQNiS7coTldh1I3hfo30= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766514375; c=relaxed/simple; bh=RoHBsR2d7Q7GCEaIb6tf03AqPf/851ZIscm+O+20wZU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ho4BSBYizOSrA6mCYCNTIXGHEjhYMPYcYhBI99BbmSbTknHFx7CmXB0SfnJjsiMtja3I6PhLf+1EZfqwVYTyV2bgtzOdIrUWG8B4FLatjrG3Z3gI8beq0ypdToHU6DJP4rzdA0ojAQrAosIaPDEABC1nVARv5FuLUPF0Qic7aI0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=S0G+kzVJ; arc=none smtp.client-ip=209.85.210.68 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="S0G+kzVJ" Received: by mail-ot1-f68.google.com with SMTP id 46e09a7af769-7cc50eb0882so1824416a34.3 for ; Tue, 23 Dec 2025 10:26:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1766514371; x=1767119171; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=rUORSJ39qI0pVVDF1Dm7SJIUnfZq9zH2suoH4Wp242g=; b=S0G+kzVJ8g9f8KRpI+195+U7anLS1emPBc5PnYGgYbYg4cCP0al8BzDvEnl6zF9LQ6 lRDO3SDhOpgsu9sZIKl5OMPl+++zEq8pQ7hp/ZcRjEshd7/oO3KdYWhq3gFH6Z6nb1EE HZLAKwSaTa0lRr0zUr4QYuhqkRMQdiKbVDtLO1Wu5FlSrfjv+9njSrF9se0T1z70XQ74 2Wz2wcCdkOlSHi0sD8Fev9QYL4xbgTK7aVp+a1p0/VBCavRgN89ZZqbHOLExJ+rP860e Z6+vZI5uAIzxpu6p8TMcyMlcchak+WLHHoepTpf3vYQSDPndtwiz8sJNg0XXRR6REi8n dw2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766514371; x=1767119171; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=rUORSJ39qI0pVVDF1Dm7SJIUnfZq9zH2suoH4Wp242g=; b=JZkSwkhvJ90/j0HXnW93vuvkBkoMyIsfQbvNabrVn14RstS4mm7qDNZZPPM5N0JDNl 7E8ejWbWQlU17cGJ4Q0qab1Apm7Kn8U3DYkIUr1V7lhksSmrqz0ohmYy2FfuiuIYvMp3 QdqF+mVrc4mRLlO9VIijCsvgJohfK1+WxXUMGPLZQgYUZvXu21L8LZslKrWQn5Qx7wrM W/T8pMLTBxh4XOTfYEP1Dtpq55lUv4OXhn2wa8k4VB2hwMy0fKueOoeKEDgFwLRk5MXK sqdWTb0eaV6iR0VGechuj2cIbC1lpWCQ6D/mZO7laZexdq2Fdd/wY3ICinXWvG9vsdNV Rbww== X-Forwarded-Encrypted: i=1; AJvYcCUJ36OdrtAWXiPjIlRvlbwUwXU/9KDMnXW2KfREYn7t1nbKj4/V1InYUN8TFnUZh092uG3+hrKmaDhlHrY=@vger.kernel.org X-Gm-Message-State: AOJu0YwfRKLgPPllui6VKj+SFeaAMrnDujqHJjSrvpuy8pAax6cd/iBn gEv5Z4DeSPog2nhIpLRto58RKuW7bkZVAlqUJjGiodpXh+U9r47aMI+zBmQOpTrHdNU= X-Gm-Gg: AY/fxX6Pyr+aRvZeLNXnDMtvuq3J1hNQ7WvcHblJJB2R0L28ELiSECoCFAEYQL9ah0B I5/5FZW1UJ8nWLBtEM1IhjTepmZNwDowvbCDsaxv5RY6d8E19bRXwHGW4A9qDcftyMmgGBSvPAT R+pK/q+GrKBCkZanaQsuLrlMUHLBIY8JI8rOXm0U5AEv3/hz3RN9CU+B3/1QOMHCw7/0df/TwRW eEfCGeRe3CqkTyM+4VGEWPx0YOzqYYuy7KIuwOfr/3WybdLFMU4+IKGLeLsBSBMhAQ+e4oFW/UZ d9EnBF2WTshywbp5iCep9I/y+I3jExxmmgxGp14Q325/1mPCC42mEi06TLwdQTPWd/nVdcwTtsc XBGbep782Sd40ciRX/c6JmOpo+YG6ay2G8YGHmlJT2RXVoNtQAnCojLXaQ7AwKkzIPYMOPuWZCs /UFdNw9er9fHAVKObhk75f1mLwD10+6aVW/pUwZb2IwmPuH/ddLEibN6Karaqe X-Google-Smtp-Source: AGHT+IFWB9BxicOq7wmIDOM/3f0UNSdBE+rFuZQtSZ+yjTAo0rb918LQDr9/t4N17Ri1ZdbA1IFJXg== X-Received: by 2002:a05:6830:230e:b0:7c7:731:7905 with SMTP id 46e09a7af769-7cc66a4b7a2mr6616842a34.24.1766514371411; Tue, 23 Dec 2025 10:26:11 -0800 (PST) Received: from ?IPV6:2600:8803:e7e4:500:fe29:88f1:f763:378b? ([2600:8803:e7e4:500:fe29:88f1:f763:378b]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-7cc6673bdabsm9706228a34.10.2025.12.23.10.26.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 23 Dec 2025 10:26:10 -0800 (PST) Message-ID: <56c03c7f-1e5b-4586-beb0-47a1fa3bc86c@baylibre.com> Date: Tue, 23 Dec 2025 12:26:09 -0600 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] dt-bindings: iio: adc: add Texas Instruments TLA 2528 To: Maxime Chevallier , Jonathan Cameron , nuno.sa@analog.com, Andy Shevchenko , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Marcelo Schmitt , Matti Vaittinen , Antoniu Miclaus , Angelo Dureghello , Tobias Sperling , Eason Yang , Marilene Andrade Garcia , Cosmin Tanislav , duje@dujemihanovic.xyz, herve.codina@bootlin.com, Rodolfo Giometti Cc: linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, thomas.petazzoni@bootlin.com References: <20251223155534.220504-1-maxime.chevallier@bootlin.com> <20251223155534.220504-2-maxime.chevallier@bootlin.com> Content-Language: en-US From: David Lechner In-Reply-To: <20251223155534.220504-2-maxime.chevallier@bootlin.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 12/23/25 9:55 AM, Maxime Chevallier wrote: > The TI TLA 2528 is a simple 8 channel, 12-bit ADC? Add a binding TLA2528 (no space). Also, why the "?"? > documentation for it. > > Signed-off-by: Maxime Chevallier > --- > .../bindings/iio/adc/ti,tla2528.yaml | 48 +++++++++++++++++++ > 1 file changed, 48 insertions(+) > create mode 100644 Documentation/devicetree/bindings/iio/adc/ti,tla2528.yaml > > diff --git a/Documentation/devicetree/bindings/iio/adc/ti,tla2528.yaml b/Documentation/devicetree/bindings/iio/adc/ti,tla2528.yaml > new file mode 100644 > index 000000000000..0ee326d77014 > --- /dev/null > +++ b/Documentation/devicetree/bindings/iio/adc/ti,tla2528.yaml > @@ -0,0 +1,48 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/iio/adc/ti,tla2528.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Texas Instruments TLA2528 8-channel 12bit I2C ADC 12-bit > + > +maintainers: > + - Maxime Chevallier > + > +description: | > + 12bit 8-channel I2C ADC. The title already says this. Either drop it or add new info. Also, don't need the |. > + > +properties: > + compatible: > + const: ti,tla2528 > + > + reg: > + maxItems: 1 > + > + vref-supply: > + description: Supply for 2.35V to 5.5V reference voltage According the the datasheet, there are AVDD and DVDD supplies. Nothing named VREF or REF. So instead: avdd-supply: true dvdd-supply: true It looks like inputs can also be used as GPIOs, so gpio-controller: true #gpio-cells: const: 2 would be appropriate (it doesn't matter if the driver doesn't implement it, we know what the correct bindings are). > + > + "#io-channel-cells": > + const: 1 > + > +required: > + - compatible > + - reg > + - vref-supply > + > +unevaluatedProperties: false > + > +examples: > + - | > + i2c { > + #address-cells = <1>; > + #size-cells = <0>; > + > + adc@17 { > + compatible = "ti,tla2528"; > + reg = <0x17>; > + vref-supply = <®_adc_supply>; > + #io-channel-cells = <1>; > + }; > + }; > +...