From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EC044C433E0 for ; Mon, 3 Aug 2020 23:18:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 011B920781 for ; Mon, 3 Aug 2020 23:18:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=kernel-dk.20150623.gappssmtp.com header.i=@kernel-dk.20150623.gappssmtp.com header.b="teumh6vg" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729188AbgHCXSH (ORCPT ); Mon, 3 Aug 2020 19:18:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58206 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729028AbgHCXSH (ORCPT ); Mon, 3 Aug 2020 19:18:07 -0400 Received: from mail-pl1-x642.google.com (mail-pl1-x642.google.com [IPv6:2607:f8b0:4864:20::642]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4F304C06174A for ; Mon, 3 Aug 2020 16:18:07 -0700 (PDT) Received: by mail-pl1-x642.google.com with SMTP id u10so12332584plr.7 for ; Mon, 03 Aug 2020 16:18:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:from:to:cc:references:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=mE1Zo4WQEH1D2xB2gURPFr+G+GxzoBMDDrUhK5+OwFw=; b=teumh6vgDlENKBXvNps2s40IxXmmMolX/zwdU6vj+I+rAzmtej4e+I4hWjJVbRIBfZ kpTUCYsfLF2CxRHZu+Q+I+k+4wJZ76xv2Voa0HQrNLmk/3kXuAxdU8jqK6lpqRM9JOpV j5YjyrxuorlMvw0cAJUlI8bt2HBDD1MJzL634YzjkSBy5ExCsyVPEst45m1VjTJna3BF gRln5o5p8Muhl37cjLab4gwQNqbN9iexBBIVAVFo7fT6FOlTfdFZiongiAt7Lp+8mWIb KrR1wCzvpN7waxNjDi3qmP+31XH7FSw5MlVsyAezJ8KBEKOldNzlaxosMwUKKaP654t5 IJog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:from:to:cc:references:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=mE1Zo4WQEH1D2xB2gURPFr+G+GxzoBMDDrUhK5+OwFw=; b=i/D8k12g/qZbL9MoW3pmaFmOiRlXzus8DOJqcdNhyIpBa8tDeG6V6v50u0A6ZLX0Vb +QkAWWN+KjFnszfj+nxd+MoLNB+9JN6Il/x6baGL8F8fB1pkykHuk0y32cN3/ZH4hFHS 4nNqWe+wXF7fgMdVvcnkvOO96MXeNluKuvBO6QyjgKMvkNUD2TKzrJEmquVqYuGEa8JP PGU/fRoYrmjbT2T1gQWDxFWNAt7Gr7c/mUC1Wg34++eU0hvGpayGx7PDlmhIku8BSaw+ UT7IgHAEVy4755ZUNibtHVpnj7eW0kFQdf4ly+1rH+yBe/rHpevzXaYKnBi0mocD6Xw1 9V3w== X-Gm-Message-State: AOAM531xH7lNinLnm9pmCeQ9d7ZzoGTex2C9Y+TJwQXpIRJlVU6ELr4Y 0UTtvd65vbFFhs9Adre2ZWCZPAPlH/A= X-Google-Smtp-Source: ABdhPJyQ5beWiMDHZPKIOLmFs1yKzbJR+bIyuu4IFSXxWGZN6GmcaFXB9zUHuO4PVaq2DzCprWVemw== X-Received: by 2002:a17:90a:6b07:: with SMTP id v7mr1627114pjj.138.1596496686230; Mon, 03 Aug 2020 16:18:06 -0700 (PDT) Received: from [192.168.1.182] ([66.219.217.173]) by smtp.gmail.com with ESMTPSA id g7sm516252pjj.2.2020.08.03.16.18.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 03 Aug 2020 16:18:05 -0700 (PDT) Subject: Re: [GIT PULL] io_uring changes for 5.9-rc1 From: Jens Axboe To: Linus Torvalds Cc: io-uring , "linux-kernel@vger.kernel.org" References: <50466810-9148-e245-7c1e-e7435b753582@kernel.dk> Message-ID: <56cb11b1-7943-086e-fb31-6564f4d4d089@kernel.dk> Date: Mon, 3 Aug 2020 17:18:04 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 8/3/20 4:30 PM, Jens Axboe wrote: >> Adding random kiocb helper functions to a core header file, when they >> are only used in one place, and when they only make sense in that one >> place? >> >> Not ok. > > I'll move that into io_uring instead. I see that you handled most of the complaints already, so thanks for that. I've run some basic testing with master and it works for me, running some more testing on production too. I took a look at the rewrite you queued up, and made a matching change on the io_uring side: https://git.kernel.dk/cgit/linux-block/commit/?h=io_uring-5.9&id=419ebeb6f2d0d56f6b2844c0f77034d1048e37e9 and also queued a documentation patch for the retry logic and the callback handler: https://git.kernel.dk/cgit/linux-block/commit/?h=io_uring-5.9&id=9541a9d4791c2d31ba74b92666edd3f1efd936a8 For the latter, let me know if you're happy with the explanation, or if you want other parts documented more thoroughly too. I'll make a pass through the file in any case once I've flushed out the other branches for this merge window in. -- Jens Axboe