From: David Hunter <david.hunter.linux@gmail.com>
To: Raphael Pinsonneault-Thibeault <rpthibeault@gmail.com>,
almaz.alexandrovich@paragon-software.com
Cc: ntfs3@lists.linux.dev, linux-kernel@vger.kernel.org,
skhan@linuxfoundation.org,
syzbot+7a2ba6b7b66340cff225@syzkaller.appspotmail.com
Subject: Re: [PATCH] ntfs3: fix uninit memory after failed mi_read in mi_format_new
Date: Sun, 28 Sep 2025 11:17:26 -0400 [thread overview]
Message-ID: <56d8cad5-d8ab-436d-bad0-c631e414c70d@gmail.com> (raw)
In-Reply-To: <20250925203701.223744-2-rpthibeault@gmail.com>
On 9/25/25 16:36, Raphael Pinsonneault-Thibeault wrote:
> attr_insert_range() called from ntfs_fallocate() has 2 different
> code paths that trigger mi_read() (which calls ntfs_read_bh).
> If the first mi_read() -> ntfs_read_bh() fails with an IO error, it
> leaves an uninitialized buffer in the buffer cache.
> The second mi_read() -> ntfs_read_bh() then uses that buffer,
> where we get KMSAN warning "uninit-value in ntfs_read_bh".
>
> The fix is to check if mi_read failed in mi_format_new.
>
Did you do any testing for this patch?
David Hunter
next prev parent reply other threads:[~2025-09-28 15:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-25 20:36 [PATCH] ntfs3: fix uninit memory after failed mi_read in mi_format_new Raphael Pinsonneault-Thibeault
2025-09-28 15:17 ` David Hunter [this message]
2025-09-28 15:25 ` David Hunter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56d8cad5-d8ab-436d-bad0-c631e414c70d@gmail.com \
--to=david.hunter.linux@gmail.com \
--cc=almaz.alexandrovich@paragon-software.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ntfs3@lists.linux.dev \
--cc=rpthibeault@gmail.com \
--cc=skhan@linuxfoundation.org \
--cc=syzbot+7a2ba6b7b66340cff225@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox