From: Michael Straube <straube.linux@gmail.com>
To: Emily Peri <eperi1024@gmail.com>,
Praveen Kumar <kumarpraveen@linux.microsoft.com>
Cc: gregkh@linuxfoundation.org, outreachy@lists.linux.dev,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] staging: rtl8723bs: fix white space warnings
Date: Thu, 20 Oct 2022 07:59:01 +0200 [thread overview]
Message-ID: <56f4cf2c-bc9f-e6a3-d7a0-7f293465166e@gmail.com> (raw)
In-Reply-To: <Y1DXNYai6M6niWXQ@marshmallow>
On 10/20/22 07:05, Emily Peri wrote:
>>>
>>> *pold_state = networktype;
>>>
>>> @@ -367,7 +368,7 @@ u8 rtw_set_802_11_disassociate(struct adapter *padapter)
>>>
>>> u8 rtw_set_802_11_bssid_list_scan(struct adapter *padapter, struct ndis_802_11_ssid *pssid, int ssid_max_num)
>>> {
>>> - struct mlme_priv *pmlmepriv = &padapter->mlmepriv;
>>> + struct mlme_priv *pmlmepriv = &padapter->mlmepriv;
>>> u8 res = true;
>>>
>>> if (!padapter) {
>>
>> Regards,
>>
>> ~Praveen.
>
> Now that I think about-- in this last edit I removed a space to appease
> checkpatch, but maybe I actually should have removed the tab?
Hi Emily,
you are right, just use spaces.
struct mlme_priv *pmlmepriv = &padapter->mlmepriv;
thanks,
Michael
next prev parent reply other threads:[~2022-10-20 5:59 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-20 2:10 [PATCH 0/3] staging: rtl8723bs: clean up driver code in rtw_ioctl_set Emily Peri
2022-10-20 2:10 ` [PATCH 1/3] staging: rtl8723bs: fix white space warnings Emily Peri
2022-10-20 4:04 ` Praveen Kumar
2022-10-20 5:05 ` Emily Peri
2022-10-20 5:59 ` Michael Straube [this message]
2022-10-20 4:57 ` Greg KH
2022-10-20 5:28 ` Emily Peri
2022-10-20 7:07 ` Greg KH
2022-10-20 2:10 ` [PATCH 2/3] staging: rtl8723bs: align block comment stars Emily Peri
2022-10-20 2:10 ` [PATCH 3/3] staging: rtl8723bs: remove unnecessary parenthesis Emily Peri
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56f4cf2c-bc9f-e6a3-d7a0-7f293465166e@gmail.com \
--to=straube.linux@gmail.com \
--cc=eperi1024@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=kumarpraveen@linux.microsoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=outreachy@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox