From: Chao Yu <chao@kernel.org>
To: Mukesh Ojha <quic_mojha@quicinc.com>,
jaegeuk@kernel.org, mhiramat@kernel.org
Cc: quic_pkondeti@quicinc.com, linux-kernel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [f2fs-dev] [PATCH v2 1/2] f2fs: fix the assign logic of iocb
Date: Sat, 29 Oct 2022 10:55:13 +0800 [thread overview]
Message-ID: <56fbc5fb-4c82-005c-5cc9-84dfaeddf106@kernel.org> (raw)
In-Reply-To: <1666861961-12924-1-git-send-email-quic_mojha@quicinc.com>
On 2022/10/27 17:12, Mukesh Ojha wrote:
> commit 18ae8d12991b ("f2fs: show more DIO information in tracepoint")
> introduces iocb field in 'f2fs_direct_IO_enter' trace event
> And it only assigns the pointer and later it accesses its field
> in trace print log.
>
> Unable to handle kernel paging request at virtual address ffffffc04cef3d30
> Mem abort info:
> ESR = 0x96000007
> EC = 0x25: DABT (current EL), IL = 32 bits
>
> pc : trace_raw_output_f2fs_direct_IO_enter+0x54/0xa4
> lr : trace_raw_output_f2fs_direct_IO_enter+0x2c/0xa4
> sp : ffffffc0443cbbd0
> x29: ffffffc0443cbbf0 x28: ffffff8935b120d0 x27: ffffff8935b12108
> x26: ffffff8935b120f0 x25: ffffff8935b12100 x24: ffffff8935b110c0
> x23: ffffff8935b10000 x22: ffffff88859a936c x21: ffffff88859a936c
> x20: ffffff8935b110c0 x19: ffffff8935b10000 x18: ffffffc03b195060
> x17: ffffff8935b11e76 x16: 00000000000000cc x15: ffffffef855c4f2c
> x14: 0000000000000001 x13: 000000000000004e x12: ffff0000ffffff00
> x11: ffffffef86c350d0 x10: 00000000000010c0 x9 : 000000000fe0002c
> x8 : ffffffc04cef3d28 x7 : 7f7f7f7f7f7f7f7f x6 : 0000000002000000
> x5 : ffffff8935b11e9a x4 : 0000000000006250 x3 : ffff0a00ffffff04
> x2 : 0000000000000002 x1 : ffffffef86a0a31f x0 : ffffff8935b10000
> Call trace:
> trace_raw_output_f2fs_direct_IO_enter+0x54/0xa4
> print_trace_fmt+0x9c/0x138
> print_trace_line+0x154/0x254
> tracing_read_pipe+0x21c/0x380
> vfs_read+0x108/0x3ac
> ksys_read+0x7c/0xec
> __arm64_sys_read+0x20/0x30
> invoke_syscall+0x60/0x150
> el0_svc_common.llvm.1237943816091755067+0xb8/0xf8
> do_el0_svc+0x28/0xa0
>
> Fix it by copying the required variables for printing and while at
> it fix the similar issue at some other places in the same file.
>
> Fixes: 18ae8d12991b ("f2fs: show more DIO information in tracepoint")
> Signed-off-by: Mukesh Ojha <quic_mojha@quicinc.com>
Reviewed-by: Chao Yu <chao@kernel.org>
Thanks,
prev parent reply other threads:[~2022-10-29 2:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-27 9:12 [PATCH v2 1/2] f2fs: fix the assign logic of iocb Mukesh Ojha
2022-10-27 9:12 ` [PATCH 2/2] f2fs: fix the msg data type Mukesh Ojha
2022-10-27 10:17 ` Pavan Kondeti
2022-10-27 10:30 ` Pavan Kondeti
2022-10-29 2:55 ` Chao Yu
2022-10-29 2:55 ` Chao Yu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56fbc5fb-4c82-005c-5cc9-84dfaeddf106@kernel.org \
--to=chao@kernel.org \
--cc=jaegeuk@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=quic_mojha@quicinc.com \
--cc=quic_pkondeti@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox