[PATCH 0/2] initial usb support for ExynosAutov920 soc

[PATCH 0/2] initial usb support for ExynosAutov920 soc

[Pritam Manohar Sutar]

This SoC has a DWC3 compatible USB controller

The USB 3.1 DRD controller has the following features:
    * compliant with both USB device 3.1 and USB device 2.0 standards
    * compliant with USB host 3.1 and USB host 2.0 standards
    * supports USB device 3.1 and USB device 2.0 interfaces
    * supports USB host 3.1 and USB host 2.0 interfaces
    * full-speed (12 Mbps) and high-speed (480 Mbps) modes with USB device
      2.0 interface
    * super-speed (5 Gbps) mode with USB device 3.1 Gen1 interface
    * super-speed plus (10 Gbps) mode with USB device 3.1 Gen2 interface
    * single USB port which can be used for USB 3.1 or USB 2.0
    * on-chip USB PHY transceiver
    * DWC3 compatible
    * supports up to 16 bi-directional endpoints
    * compliant with xHCI 1.1 specification

Pritam Manohar Sutar (2):
  dt-bindings: usb: samsung,exynos-dwc3: add dt-schema ExynosAutov920
  usb: dwc3-exynos: add support for ExynosAutov920

 .../bindings/usb/samsung,exynos-dwc3.yaml        | 16 ++++++++++++++++
 drivers/usb/dwc3/dwc3-exynos.c                   |  9 +++++++++
 2 files changed, 25 insertions(+)

-- 
2.34.1

[PATCH 1/2] dt-bindings: usb: samsung,exynos-dwc3: add dt-schema ExynosAutov920

[Pritam Manohar Sutar]

Add a dedicated compatible for USB controller found in this SoC

Signed-off-by: Pritam Manohar Sutar <pritam.sutar@samsung.com>
---
 .../bindings/usb/samsung,exynos-dwc3.yaml        | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)

diff --git a/Documentation/devicetree/bindings/usb/samsung,exynos-dwc3.yaml b/Documentation/devicetree/bindings/usb/samsung,exynos-dwc3.yaml
index 892545b477ac..6d39e5066944 100644
--- a/Documentation/devicetree/bindings/usb/samsung,exynos-dwc3.yaml
+++ b/Documentation/devicetree/bindings/usb/samsung,exynos-dwc3.yaml
@@ -20,6 +20,7 @@ properties:
           - samsung,exynos7-dwusb3
           - samsung,exynos7870-dwusb3
           - samsung,exynos850-dwusb3
+          - samsung,exynosautov920-dwusb3
       - items:
           - const: samsung,exynos990-dwusb3
           - const: samsung,exynos850-dwusb3
@@ -179,6 +180,21 @@ allOf:
       required:
         - vdd10-supply
 
+  - if:
+      properties:
+        compatible:
+          contains:
+            const: samsung,exynosautov920-dwusb3
+    then:
+      properties:
+        clocks:
+          minItems: 2
+          maxItems: 2
+        clock-names:
+          items:
+            - const: ref
+            - const: susp_clk
+
 additionalProperties: false
 
 examples:
-- 
2.34.1

Re: [PATCH 1/2] dt-bindings: usb: samsung,exynos-dwc3: add dt-schema ExynosAutov920

[Krzysztof Kozlowski]

On 14/05/2025 16:07, Pritam Manohar Sutar wrote:

>  
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            const: samsung,exynosautov920-dwusb3
> +    then:
> +      properties:
> +        clocks:
> +          minItems: 2
> +          maxItems: 2
> +        clock-names:
> +          items:
> +            - const: ref
> +            - const: susp_clk
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof

RE: [PATCH 1/2] dt-bindings: usb: samsung,exynos-dwc3: add dt-schema ExynosAutov920

[Alim Akhtar]

Hi Pritam

> -----Original Message-----
> From: Pritam Manohar Sutar <pritam.sutar@samsung.com>
> Sent: Wednesday, May 14, 2025 7:38 PM
> To: pritam.sutar@samsung.com; gregkh@linuxfoundation.org;
> robh@kernel.org; krzk+dt@kernel.org; conor+dt@kernel.org;
> alim.akhtar@samsung.com; Thinh.Nguyen@synopsys.com
> Cc: linux-usb@vger.kernel.org; devicetree@vger.kernel.org; linux-arm-
> kernel@lists.infradead.org; linux-samsung-soc@vger.kernel.org; linux-
> kernel@vger.kernel.org; rosa.pila@samsung.com; dev.tailor@samsung.com;
> faraz.ata@samsung.com; muhammed.ali@samsung.com;
> selvarasu.g@samsung.com
> Subject: [PATCH 1/2] dt-bindings: usb: samsung,exynos-dwc3: add dt-
> schema ExynosAutov920
> 
> Add a dedicated compatible for USB controller found in this SoC
> 
> Signed-off-by: Pritam Manohar Sutar <pritam.sutar@samsung.com>
> ---
Reviewed-by: Alim Akhtar <alim.akhtar@samsung.com>

[PATCH 2/2] usb: dwc3-exynos: add support for ExynosAutov920

[Pritam Manohar Sutar]

This SoC has a DWC3 compatible controllers. It needs "ref" and
"susp_clk" for it's operation.

Add required changes in exynos dwc3 glue layer to support this SoC.

Signed-off-by: Pritam Manohar Sutar <pritam.sutar@samsung.com>
---
 drivers/usb/dwc3/dwc3-exynos.c | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/drivers/usb/dwc3/dwc3-exynos.c b/drivers/usb/dwc3/dwc3-exynos.c
index 20abc6a4e824..a8f97d2b31ae 100644
--- a/drivers/usb/dwc3/dwc3-exynos.c
+++ b/drivers/usb/dwc3/dwc3-exynos.c
@@ -187,6 +187,12 @@ static const struct dwc3_exynos_driverdata gs101_drvdata = {
 	.suspend_clk_idx = 1,
 };
 
+static const struct dwc3_exynos_driverdata exynosautov920_drvdata = {
+	.clk_names = { "ref", "susp_clk"},
+	.num_clks = 2,
+	.suspend_clk_idx = 1,
+};
+
 static const struct of_device_id exynos_dwc3_match[] = {
 	{
 		.compatible = "samsung,exynos2200-dwusb3",
@@ -209,6 +215,9 @@ static const struct of_device_id exynos_dwc3_match[] = {
 	}, {
 		.compatible = "google,gs101-dwusb3",
 		.data = &gs101_drvdata,
+	}, {
+		.compatible = "samsung,exynosautov920-dwusb3",
+		.data = &exynosautov920_drvdata,
 	}, {
 	}
 };
-- 
2.34.1

Re: [PATCH 2/2] usb: dwc3-exynos: add support for ExynosAutov920

[Thinh Nguyen]

On Wed, May 14, 2025, Pritam Manohar Sutar wrote:
> This SoC has a DWC3 compatible controllers. It needs "ref" and
> "susp_clk" for it's operation.
> 
> Add required changes in exynos dwc3 glue layer to support this SoC.
> 
> Signed-off-by: Pritam Manohar Sutar <pritam.sutar@samsung.com>
> ---
>  drivers/usb/dwc3/dwc3-exynos.c | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/drivers/usb/dwc3/dwc3-exynos.c b/drivers/usb/dwc3/dwc3-exynos.c
> index 20abc6a4e824..a8f97d2b31ae 100644
> --- a/drivers/usb/dwc3/dwc3-exynos.c
> +++ b/drivers/usb/dwc3/dwc3-exynos.c
> @@ -187,6 +187,12 @@ static const struct dwc3_exynos_driverdata gs101_drvdata = {
>  	.suspend_clk_idx = 1,
>  };
>  
> +static const struct dwc3_exynos_driverdata exynosautov920_drvdata = {
> +	.clk_names = { "ref", "susp_clk"},
> +	.num_clks = 2,
> +	.suspend_clk_idx = 1,
> +};
> +
>  static const struct of_device_id exynos_dwc3_match[] = {
>  	{
>  		.compatible = "samsung,exynos2200-dwusb3",
> @@ -209,6 +215,9 @@ static const struct of_device_id exynos_dwc3_match[] = {
>  	}, {
>  		.compatible = "google,gs101-dwusb3",
>  		.data = &gs101_drvdata,
> +	}, {
> +		.compatible = "samsung,exynosautov920-dwusb3",
> +		.data = &exynosautov920_drvdata,

Would be nice to group this compatible string along with the other
samsung compatibles above and in order.

Regardless,

Acked-by: Thinh Nguyen <Thinh.Nguyen@synopsys.com>

BR,
Thinh

>  	}, {
>  	}
>  };
> -- 
> 2.34.1
> 

RE: [PATCH 2/2] usb: dwc3-exynos: add support for ExynosAutov920

[Alim Akhtar]

Hi Pritam

> -----Original Message-----
> From: Pritam Manohar Sutar <pritam.sutar@samsung.com>
> Sent: Wednesday, May 14, 2025 7:38 PM
> To: pritam.sutar@samsung.com; gregkh@linuxfoundation.org;
> robh@kernel.org; krzk+dt@kernel.org; conor+dt@kernel.org;
> 
[snip]
>  static const struct of_device_id exynos_dwc3_match[] = {
>  	{
>  		.compatible = "samsung,exynos2200-dwusb3", @@ -209,6
> +215,9 @@ static const struct of_device_id exynos_dwc3_match[] = {
>  	}, {
>  		.compatible = "google,gs101-dwusb3",
>  		.data = &gs101_drvdata,
> +	}, {
> +		.compatible = "samsung,exynosautov920-dwusb3",
> +		.data = &exynosautov920_drvdata,

Should go below " samsung,exynos2200-dwusb3" entry (as already pointed by Thinh)
With that fixed

Reviewed-by: Alim Akhtar <alim.akhtar@samsung.com>