From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752353AbcDCUgi (ORCPT ); Sun, 3 Apr 2016 16:36:38 -0400 Received: from mail-lb0-f194.google.com ([209.85.217.194]:34339 "EHLO mail-lb0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751225AbcDCUgg (ORCPT ); Sun, 3 Apr 2016 16:36:36 -0400 Subject: Re: [PATCH] staging: vme: fix bare use of 'unsigned' To: Clifton Barnes , martyn@welchs.me.uk, manohar.vanga@gmail.com, gregkh@linuxfoundation.org References: <1459464794-27986-1-git-send-email-clifton.a.barnes@gmail.com> Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org From: Martyn Welch Message-ID: <57017ECF.1060404@gmail.com> Date: Sun, 3 Apr 2016 21:36:31 +0100 User-Agent: Mozilla/5.0 (X11; Linux i686; rv:38.0) Gecko/20100101 Icedove/38.7.0 MIME-Version: 1.0 In-Reply-To: <1459464794-27986-1-git-send-email-clifton.a.barnes@gmail.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 31/03/16 23:53, Clifton Barnes wrote: > fix checkpatch.pl warning about 'Prefer 'unsigned int' to bare use of > 'unsigned'' > > Signed-off-by: Clifton Barnes Acked-by: Martyn Welch Greg: Whilst this patch seems valid and compiles fine, I no longer have access to the hardware for this driver. I'm aware this driver has been in the staging tree for a rather long time. I will check to see if there's any intention for further work to be done on this driver, if not I guess we should be looking to delete it from the staging tree. Martyn > --- > drivers/staging/vme/devices/vme_pio2_gpio.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/vme/devices/vme_pio2_gpio.c b/drivers/staging/vme/devices/vme_pio2_gpio.c > index df992c3..f52a9ed 100644 > --- a/drivers/staging/vme/devices/vme_pio2_gpio.c > +++ b/drivers/staging/vme/devices/vme_pio2_gpio.c > @@ -97,7 +97,7 @@ static void pio2_gpio_set(struct gpio_chip *chip, > } > > /* Directionality configured at board build - send appropriate response */ > -static int pio2_gpio_dir_in(struct gpio_chip *chip, unsigned offset) > +static int pio2_gpio_dir_in(struct gpio_chip *chip, unsigned int offset) > { > int data; > struct pio2_card *card = gpio_to_pio2_card(chip); > @@ -116,7 +116,8 @@ static int pio2_gpio_dir_in(struct gpio_chip *chip, unsigned offset) > } > > /* Directionality configured at board build - send appropriate response */ > -static int pio2_gpio_dir_out(struct gpio_chip *chip, unsigned offset, int value) > +static int pio2_gpio_dir_out(struct gpio_chip *chip, > + unsigned int offset, int value) > { > int data; > struct pio2_card *card = gpio_to_pio2_card(chip);