From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754139AbcDDA6o (ORCPT <rfc822;w@1wt.eu>);
	Sun, 3 Apr 2016 20:58:44 -0400
Received: from mailout4.samsung.com ([203.254.224.34]:56706 "EHLO
	mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752919AbcDDA6l (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Sun, 3 Apr 2016 20:58:41 -0400
MIME-version: 1.0
Content-type: text/plain; charset=UTF-8
X-AuditID: cbfee68d-f79e86d0000012da-4f-5701bc3bf46f
Content-transfer-encoding: 8BIT
Message-id: <5701BC3A.5070606@samsung.com>
Date: Mon, 04 Apr 2016 09:58:34 +0900
From: Chanwoo Choi <cw00.choi@samsung.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101
 Thunderbird/31.6.0
To: Nishanth Menon <nm@ti.com>, MyungJoo Ham <myungjoo.ham@samsung.com>
Cc: linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org,
        Grygorii Strashko <grygorii.strashko@ti.com>,
        Tony Lindgren <tony@atomide.com>, Lee Jones <lee.jones@linaro.org>,
        Roger Quadros <rogerq@ti.com>
Subject: Re: [PATCH V2] extcon: palmas: Drop stray IRQF_EARLY_RESUME flag
References: <1459518767-20382-1-git-send-email-nm@ti.com>
In-reply-to: <1459518767-20382-1-git-send-email-nm@ti.com>
X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrLIsWRmVeSWpSXmKPExsWyRsSkSNd6D2O4wbw9ahYrp7BY3P96lNFi
	0+NrrBaXd81hs5i9pJ/F4nbjCjaLNz/OMln0PNKy2H/Fy4HT49vXSSwed67tYfPYvKTeo2/L
	KkaP4ze2M3l83iQXwBbFZZOSmpNZllqkb5fAlTFz8Tf2gg+CFU33NjA2MK7h72Lk5JAQMJHY
	M20dO4QtJnHh3nq2LkYuDiGBFYwSp3etY4Qp+rVpERNEYhajxKddZ9hAErwCghI/Jt9j6WLk
	4GAWkJc4cikbJMwsoC4xad4iZoj6B4wSr64tY4So15JYPbcVbBuLgKrEpIM/wGw2oPj+FzfY
	QOaICkRIdJ+oBAmLCLhL/D/+DOwgZoHfjBKr1v0F2yss4ClxbsYVsJlCApYSBzfMYwWxOQWs
	JO5dPAq2WELgJbvE7zdbWCCWCUh8m3wI7FAJAVmJTQeYIR6TlDi44gbLBEaxWUjemYXwziwk
	7yxgZF7FKJpakFxQnJReZKhXnJhbXJqXrpecn7uJERiLp/89693BePuA9SFGAQ5GJR7eF+4M
	4UKsiWXFlbmHGE2BjpjILCWanA+M+LySeENjMyMLUxNTYyNzSzMlcV5FqZ/BQgLpiSWp2amp
	BalF8UWlOanFhxiZODilGhgn589cHr2JZ8OGZIOk+QY/Hn5mORH+LyqyZZOReP86jRPCWzx+
	v/E/bdo9MfbPsYhwR5XWbo0eNc/ZHeFqMSKzM9K+1z9y+SvwekbxG3WFXRnCldfnfmMIe+55
	0y9/HYNHzV9994j1nifmqLXlfDWqy3CW45SeNb10QWVRG+ecHZo65jt1ryixFGckGmoxFxUn
	AgCBz8gIwAIAAA==
X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrFIsWRmVeSWpSXmKPExsVy+t9jQV3rPYzhBjN+K1isnMJicf/rUUaL
	TY+vsVpc3jWHzWL2kn4Wi9uNK9gs3vw4y2TR80jLYv8VLwdOj29fJ7F43Lm2h81j85J6j74t
	qxg9jt/YzuTxeZNcAFtUA6NNRmpiSmqRQmpecn5KZl66rZJ3cLxzvKmZgaGuoaWFuZJCXmJu
	qq2Si0+ArltmDtBJSgpliTmlQKGAxOJiJX07TBNCQ9x0LWAaI3R9Q4LgeowM0EDCGsaMmYu/
	sRd8EKxoureBsYFxDX8XIyeHhICJxK9Ni5ggbDGJC/fWs3UxcnEICcxilPi06wwbSIJXQFDi
	x+R7LF2MHBzMAvISRy5lg4SZBdQlJs1bxAxR/4BR4tW1ZYwQ9VoSq+e2soPYLAKqEpMO/gCz
	2YDi+1/cYAOZIyoQIdF9ohIkLCLgLvH/+DOwvcwCvxklVq37C7ZXWMBT4tyMK2AzhQQsJQ5u
	mMcKYnMKWEncu3iUeQIj0JUI581COG8WkvMWMDKvYpRILUguKE5KzzXKSy3XK07MLS7NS9dL
	zs/dxAiO92fSOxgP73I/xCjAwajEwzvBlSFciDWxrLgy9xCjBAezkggv+y7GcCHelMTKqtSi
	/Pii0pzU4kOMpkD/TWSWEk3OB6aivJJ4Q2MTMyNLI3NDCyNjcyVx3sf/14UJCaQnlqRmp6YW
	pBbB9DFxcEo1MGYZG58rmrY0R9ZRSiri7u22x0VmZ6cnp/uscGzetCKLs/cPk/bXqIV6C49s
	WqNzWJXjc6HZW+Ugx+BfBY7xjv/PSyo/LtR1YlRg2+4uVv13/nQzTecgVQevKCvnjdxn/Z6K
	r0jL1a564736XN3SaeKNu6RFC/80FjO8nr3697M5pj9kX5/crsRSnJFoqMVcVJwIAMeUx40N	AwAA
DLP-Filter: Pass
X-MTR: 20000000000000000@CPGS
X-CFilter-Loop: Reflected
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 2016년 04월 01일 22:52, Nishanth Menon wrote:
> Palmas extcon IRQs are nested threaded and wired to the Palmas
> interrupt controller. So, this flag is not required for nested
> IRQs anymore, since commit 3c646f2c6aa9 ("genirq: Don't suspend
> nested_thread irqs over system suspend") was merged. However, the
> fix in commit ae64e42cc2b3 ("extcon: palmas: Drop IRQF_EARLY_RESUME
> flag") missed a stray flag causing the following crash on resume on
> BeagleBoard-X15 platform:
> 
> [   53.670141] Unhandled fault: imprecise external abort (0x1406) at 0x00000000
> [..]
> [   53.670141] [<c04ae734>] (omap_set_gpio_triggering) from [<c04aeb94>] (omap_gpio_unmask_irq+0xc0/0xc4)
> [   53.670141] [<c04aeb94>] (omap_gpio_unmask_irq) from [<c01a0b88>] (irq_enable+0x30/0x44)
> [   53.670141] [<c01a0b88>] (irq_enable) from [<c019ebd8>] (__enable_irq+0x54/0x78)
> [   53.670141] [<c019ebd8>] (__enable_irq) from [<c01a4e60>] (resume_irqs+0xe8/0x100)
> [   53.670141] [<c01a4e60>] (resume_irqs) from [<c0514840>] (syscore_resume+0x94/0x298)
> [   53.670141] [<c0514840>] (syscore_resume) from [<c01981cc>] (suspend_devices_and_enter+0x790/0x9e4)
> [   53.670141] [<c01981cc>] (suspend_devices_and_enter) from [<c0198a60>] (pm_suspend+0x640/0x75c)
> [   53.670141] [<c0198a60>] (pm_suspend) from [<c0196bec>] (state_store+0x64/0xb8)
> [   53.670141] [<c0196bec>] (state_store) from [<c0307944>] (kernfs_fop_write+0xc0/0x1bc)
> [   53.670141] [<c0307944>] (kernfs_fop_write) from [<c028acb0>] (__vfs_write+0x1c/0xd8)
> [   53.670141] [<c028acb0>] (__vfs_write) from [<c028bba0>] (vfs_write+0x90/0x16c)
> [   53.670141] [<c028bba0>] (vfs_write) from [<c028c8c0>] (SyS_write+0x44/0x9c)
> [   53.670141] [<c028c8c0>] (SyS_write) from [<c0107840>] (ret_fast_syscall+0x0/0x1c)
> [..]
> 
> Fixes: ae64e42cc2b3 ("extcon: palmas: Drop IRQF_EARLY_RESUME flag")
> Cc: Grygorii Strashko <grygorii.strashko@ti.com>
> Cc: MyungJoo Ham <myungjoo.ham@samsung.com>
> Cc: Chanwoo Choi <cw00.choi@samsung.com>
> Cc: Tony Lindgren <tony@atomide.com>
> Cc: Lee Jones <lee.jones@linaro.org>
> Cc: Roger Quadros <rogerq@ti.com>
> 
> Reviewed-by: Grygorii Strashko <grygorii.strashko@ti.com>
> Signed-off-by: Nishanth Menon <nm@ti.com>

Applied it.

Thanks,
Chanwoo Choi