From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752408AbcDDDmn (ORCPT ); Sun, 3 Apr 2016 23:42:43 -0400 Received: from mailout3.w1.samsung.com ([210.118.77.13]:24047 "EHLO mailout3.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751046AbcDDDml (ORCPT ); Sun, 3 Apr 2016 23:42:41 -0400 X-AuditID: cbfec7f5-f792a6d000001302-57-5701e2ae46d3 Subject: Re: [PATCH 4/7] drivers/mfd: make max14577.c explicitly non-modular To: Paul Gortmaker , linux-kernel@vger.kernel.org References: <1459718659-28316-1-git-send-email-paul.gortmaker@windriver.com> <1459718659-28316-5-git-send-email-paul.gortmaker@windriver.com> Cc: Chanwoo Choi , Samuel Ortiz , Lee Jones , Javier Martinez Canillas From: Krzysztof Kozlowski Message-id: <5701E2AA.5070208@samsung.com> Date: Mon, 04 Apr 2016 12:42:34 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-version: 1.0 In-reply-to: <1459718659-28316-5-git-send-email-paul.gortmaker@windriver.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrLLMWRmVeSWpSXmKPExsVy+t/xy7rrHjGGGzT/FLG4/uU5q8Wbt2uY LF6/MLS4//Uoo8XlXXPYLK7tPc5scbqb1YHd4861PWwe804Gemzpv8vu0bdlFaPH501yHuu3 bGUKYIvisklJzcksSy3St0vgyvg2/wlzwU/eiplrv7I2MK7j7mLk4JAQMJE43JXaxcgJZIpJ XLi3nq2LkYtDSGApo8SttufMEM5TRokH6z8yglQJC/hInOv+BGaLCPhLbN+whh2iqJ9R4t/R 9SwgDrPAckaJtV//gFWxCRhLbF6+hA3E5hXQkph36wwriM0ioCrxdFMTM4gtKhAh8WTuSUaI GkGJH5PvsYDYnAK+EmtOHGYGOZVZQE/i/kUtkDCzgLzE5jVvmScwCsxC0jELoWoWkqoFjMyr GEVTS5MLipPSc430ihNzi0vz0vWS83M3MUIC/esOxqXHrA4xCnAwKvHwfjjKGC7EmlhWXJl7 iFGCg1lJhPfWPaAQb0piZVVqUX58UWlOavEhRmkOFiVx3pm73ocICaQnlqRmp6YWpBbBZJk4 OKUaGNk+eUx1Slb9uT+vK9lExVuHN9bB4EGzZ2HW/objifvlp6Uorpp7fj+/xw6dbad9ODbe PL1P0MJ9rt4C1pyLb0omz76yd6b1vhnTE64u7QgRcld4oO1+/eACke8rWy7V/vbk9762xTvk XfXXh9tKFhTtbnVqv2Gw510fh8delnOvdU4cMQxvmavEUpyRaKjFXFScCAAwynnIcAIAAA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04.04.2016 06:24, Paul Gortmaker wrote: > The Kconfig currently controlling compilation of this code is: > > mfd/Kconfig:config MFD_MAX14577 > mfd/Kconfig: bool "Maxim Semiconductor MAX14577/77836 MUIC + Charger Support" > > ...meaning that it currently is not being built as a module by anyone. > > Lets remove the modular code that is essentially orphaned, so that > when reading the driver there is no doubt it is builtin-only. > > Since module_init was not in use by this code, the init ordering > remains unchanged with this commit. > > Also note that MODULE_DEVICE_TABLE is a no-op for non-modular code. > > We also delete the MODULE_LICENSE tag etc. since all that information > is already contained at the top of the file in the comments. > > Cc: Chanwoo Choi > Cc: Krzysztof Kozlowski > Cc: Samuel Ortiz > Cc: Lee Jones > Signed-off-by: Paul Gortmaker > --- > drivers/mfd/max14577.c | 13 +------------ > 1 file changed, 1 insertion(+), 12 deletions(-) +Cc Javier, In general I agree with the patchset except maybe here because it conflicts with Javier's work to make it a module: mfd: max14577: Use module_init() instead of subsys_initcall() http://www.spinics.net/lists/kernel/msg2213747.html Javier's patchset is however missing a tested-by tag so maybe this is why it was not merged. Unfortunately I cannot provide testing because my current device with max14577/max77836 is dead and its recovery is not easy. Maybe I will get a proper device in a few weeks after going back to Poland. My proposal would be to wait with this max14577 change a little bit. Best regards, Krzysztof