From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752951AbcDDDo6 (ORCPT ); Sun, 3 Apr 2016 23:44:58 -0400 Received: from mailout1.w1.samsung.com ([210.118.77.11]:57801 "EHLO mailout1.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751314AbcDDDo5 (ORCPT ); Sun, 3 Apr 2016 23:44:57 -0400 X-AuditID: cbfec7f4-f796c6d000001486-76-5701e3350c7d Subject: Re: [PATCH 5/7] drivers/mfd: make max77686.c explicitly non-modular To: Paul Gortmaker , linux-kernel@vger.kernel.org References: <1459718659-28316-1-git-send-email-paul.gortmaker@windriver.com> <1459718659-28316-6-git-send-email-paul.gortmaker@windriver.com> Cc: Chanwoo Choi , Samuel Ortiz , Lee Jones , Javier Martinez Canillas From: Krzysztof Kozlowski Message-id: <5701E331.5060101@samsung.com> Date: Mon, 04 Apr 2016 12:44:49 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-version: 1.0 In-reply-to: <1459718659-28316-6-git-send-email-paul.gortmaker@windriver.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrLLMWRmVeSWpSXmKPExsVy+t/xq7qmjxnDDe7P0rO4/uU5q8Wbt2uY LF6/MLS4//Uoo8XlXXPYLK7tPc5scbqb1YHd4861PWwe804Gemzpv8vu0bdlFaPH501yHuu3 bGUKYIvisklJzcksSy3St0vgypjXfZml4CxPxePdU5kaGJdwdTFyckgImEgcmXaLDcIWk7hw bz2QzcUhJLCUUaKv4RYzhPOUUWLdocdgVcICPhLvr7azg9giAv4S2zesYYco6meU2D31BguI wyywnFFi7dc/jCBVbALGEpuXLwHr5hXQknh89i9QEQcHi4CqxM1nHiBhUYEIiSdzTzJClAhK /Jh8jwXE5hTwlfjwcTIjSDmzgJ7E/YtaIGFmAXmJzWveMk9gFJiFpGMWQtUsJFULGJlXMYqm liYXFCel5xrqFSfmFpfmpesl5+duYoQE+pcdjIuPWR1iFOBgVOLh/XCUMVyINbGsuDL3EKME B7OSCO+te0Ah3pTEyqrUovz4otKc1OJDjNIcLErivHN3vQ8REkhPLEnNTk0tSC2CyTJxcEo1 MLbsbi7xW+Fx9LqX7ZtPViu1Dx16oOdwrOLP7uUzJVkkJYxO67I5vtaMvJHwa+LefZW3Fnee 2ZR0gafxrbX4DLvZbxYfC0nuvnqMVX115tJMpmNhdy6FvA66nmQWc/fTE+l1CZty9kppGEml fWgyruOTnVI1v2b1HLPbES+cV61rdt91btO14G9KLMUZiYZazEXFiQAtNTt7cAIAAA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04.04.2016 06:24, Paul Gortmaker wrote: > The Kconfig currently controlling compilation of this code is: > > drivers/mfd/Kconfig:config MFD_MAX77686 > drivers/mfd/Kconfig: bool "Maxim Semiconductor MAX77686/802 PMIC Support" > > ...meaning that it currently is not being built as a module by anyone. > > Lets remove the modular code that is essentially orphaned, so that > when reading the driver there is no doubt it is builtin-only. > > We explicitly disallow a driver unbind, since that doesn't have a > sensible use case anyway, and it allows us to drop the ".remove" > code for non-modular drivers. > > Since module_init was not in use by this code, the init ordering > remains unchanged with this commit. > > Also note that MODULE_DEVICE_TABLE is a no-op for non-modular code. > > We also delete the MODULE_LICENSE tag etc. since all that information > is already contained at the top of the file in the comments. > > Cc: Chanwoo Choi > Cc: Krzysztof Kozlowski > Cc: Samuel Ortiz > Cc: Lee Jones > Signed-off-by: Paul Gortmaker > --- > drivers/mfd/max77686.c | 26 ++------------------------ > 1 file changed, 2 insertions(+), 24 deletions(-) +Cc Javier, I think we want to proceed with Javier's work for max77686: mfd: max77686: Allow the driver to be built as a module http://lkml.iu.edu/hypermail/linux/kernel/1602.1/03921.html Javier, what is the status of your patchset? What do you need? Best regards, Krzysztof