From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757588AbcDGUrX (ORCPT ); Thu, 7 Apr 2016 16:47:23 -0400 Received: from mx1.redhat.com ([209.132.183.28]:33578 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754124AbcDGUrV convert rfc822-to-8bit (ORCPT ); Thu, 7 Apr 2016 16:47:21 -0400 Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <20160407.163616.385449823878901734.davem@davemloft.net> References: <20160407.163616.385449823878901734.davem@davemloft.net> <20160407162309.21283.11482.stgit@warthog.procyon.org.uk> <1460046677.6715.95.camel@perches.com> <1091.1460058308@warthog.procyon.org.uk> To: David Miller Cc: dhowells@redhat.com, joe@perches.com, linux-afs@lists.infradead.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/9] rxrpc: Disable a debugging statement that has been left enabled. MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <5701.1460062039.1@warthog.procyon.org.uk> Content-Transfer-Encoding: 8BIT Date: Thu, 07 Apr 2016 21:47:19 +0100 Message-ID: <5702.1460062039@warthog.procyon.org.uk> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org David Miller wrote: > > Excellent only if I can get at it to find out why the something went wrong. > > If it's lost because the machine panics, then it is worthless. > > If you're ok with these kenter things spewing into the logs with the > current facility, you can run the function tracer and have it record > into the logs all the time too. They don't do that unless you enable them. And I can enable them individually at compile time or by set at runtime. > I don't see any argument which is appropriate for keeping this stuff > around. Sigh. As I said to Joe: I don't want to deal with converting to using ftrace at the moment whilst I'm towards the end of reworking the rewrite of the code. I have a stack of patches that would need reworking yet again. David