From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755252AbcDDNlw (ORCPT ); Mon, 4 Apr 2016 09:41:52 -0400 Received: from arroyo.ext.ti.com ([192.94.94.40]:58054 "EHLO arroyo.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752017AbcDDNlu (ORCPT ); Mon, 4 Apr 2016 09:41:50 -0400 Subject: Re: [PATCH] usb: dwc3: keystone: drop dma_mask configuration To: Felipe Balbi , Greg Kroah-Hartman , References: <1459769611-16862-1-git-send-email-grygorii.strashko@ti.com> <87pou561i5.fsf@intel.com> CC: Roger Quadros , , , , Murali Karicheri From: Grygorii Strashko Message-ID: <57026F02.4060300@ti.com> Date: Mon, 4 Apr 2016 16:41:22 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <87pou561i5.fsf@intel.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/04/2016 02:45 PM, Felipe Balbi wrote: > > Hi, > > Grygorii Strashko writes: >> The Keystone 2 supports DT-boot only, as result dma_mask will be >> always configured properly from DT - >> of_platform_device_create_pdata()->of_dma_configure(). More over, >> dwc3-keystone.c can be built as module and in this case it's unsafe to >> assign local variable as dma_mask. >> >> Hence, remove dma_mask configuration code. >> >> Cc: Murali Karicheri >> Signed-off-by: Grygorii Strashko > > with these two patches from you, does USB Peripheral work on k2 devices ? I've tried CONFIG_USB_DWC3_GADGET=y + g_zero and k2e was detected as gzero dev from Host PC > > I'll drop my k2 changes from my series which I sent on saturday. > Yes, please. -- regards, -grygorii