From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755606AbcDDPVP (ORCPT ); Mon, 4 Apr 2016 11:21:15 -0400 Received: from lists.s-osg.org ([54.187.51.154]:33133 "EHLO lists.s-osg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754012AbcDDPVN (ORCPT ); Mon, 4 Apr 2016 11:21:13 -0400 Subject: Re: [PATCH 5/7] drivers/mfd: make max77686.c explicitly non-modular To: Krzysztof Kozlowski , Paul Gortmaker , linux-kernel@vger.kernel.org References: <1459718659-28316-1-git-send-email-paul.gortmaker@windriver.com> <1459718659-28316-6-git-send-email-paul.gortmaker@windriver.com> <5701E331.5060101@samsung.com> Cc: Chanwoo Choi , Samuel Ortiz , Lee Jones From: Javier Martinez Canillas Message-ID: <5702865E.3050005@osg.samsung.com> Date: Mon, 4 Apr 2016 11:21:02 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <5701E331.5060101@samsung.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Krzysztof, On 04/03/2016 11:44 PM, Krzysztof Kozlowski wrote: > On 04.04.2016 06:24, Paul Gortmaker wrote: >> The Kconfig currently controlling compilation of this code is: >> >> drivers/mfd/Kconfig:config MFD_MAX77686 >> drivers/mfd/Kconfig: bool "Maxim Semiconductor MAX77686/802 PMIC Support" >> >> ...meaning that it currently is not being built as a module by anyone. >> >> Lets remove the modular code that is essentially orphaned, so that >> when reading the driver there is no doubt it is builtin-only. >> >> We explicitly disallow a driver unbind, since that doesn't have a >> sensible use case anyway, and it allows us to drop the ".remove" >> code for non-modular drivers. >> >> Since module_init was not in use by this code, the init ordering >> remains unchanged with this commit. >> >> Also note that MODULE_DEVICE_TABLE is a no-op for non-modular code. >> >> We also delete the MODULE_LICENSE tag etc. since all that information >> is already contained at the top of the file in the comments. >> >> Cc: Chanwoo Choi >> Cc: Krzysztof Kozlowski >> Cc: Samuel Ortiz >> Cc: Lee Jones >> Signed-off-by: Paul Gortmaker >> --- >> drivers/mfd/max77686.c | 26 ++------------------------ >> 1 file changed, 2 insertions(+), 24 deletions(-) > > +Cc Javier, > > I think we want to proceed with Javier's work for max77686: > mfd: max77686: Allow the driver to be built as a module > http://lkml.iu.edu/hypermail/linux/kernel/1602.1/03921.html > > Javier, what is the status of your patchset? What do you need? > All patches but the one getting rid of the subsys initcall were already picked by Lee. I was waiting for the exynos thermal [0] patch that adds probe deferral support to land into mainline to resend that one. The patch is already in mainline so I'll do it today after testing. > Best regards, > Krzysztof > [0]: https://lkml.org/lkml/2016/2/18/592 Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America