From: "H. Peter Anvin" <hpa@zytor.com>
To: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
Andrew Morton <akpm@linux-foundation.org>,
Russell King <linux@arm.linux.org.uk>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>
Cc: linux-kernel@vger.kernel.org, linux-api@vger.kernel.org,
Paul Turner <pjt@google.com>, Andrew Hunter <ahh@google.com>,
Peter Zijlstra <peterz@infradead.org>,
Andy Lutomirski <luto@amacapital.net>,
Andi Kleen <andi@firstfloor.org>,
Dave Watson <davejwatson@fb.com>, Chris Lameter <cl@linux.com>,
Ben Maurer <bmaurer@fb.com>, Steven Rostedt <rostedt@goodmis.org>,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
Josh Triplett <josh@joshtriplett.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>,
Michael Kerrisk <mtk.manpages@gmail.com>,
Boqun Feng <boqun.feng@gmail.com>
Subject: Re: [RFC PATCH v6 1/5] Thread-local ABI system call: cache CPU number of running thread
Date: Mon, 4 Apr 2016 10:11:19 -0700 [thread overview]
Message-ID: <5702A037.60200@zytor.com> (raw)
In-Reply-To: <1459789313-4917-2-git-send-email-mathieu.desnoyers@efficios.com>
On 04/04/16 10:01, Mathieu Desnoyers wrote:
>
> Changes since v5:
> - Rename "getcpu_cache" to "thread_local_abi", allowing to extend
> this system call to cover future features such as restartable critical
> sections. Generalizing this system call ensures that we can add
> features similar to the cpu_id field within the same cache-line
> without having to track one pointer per feature within the task
> struct.
> - Add a tlabi_nr parameter to the system call, thus allowing to extend
> the ABI beyond the initial 64-byte structure by registering structures
> with tlabi_nr greater than 0. The initial ABI structure is associated
> with tlabi_nr 0.
> - Rebased on kernel v4.5.
>
This seems absolutely insanely complex, both for the kernel and for
userspace.
A much saner way would be for userspace to query the kernel for the size
of the structure; userspace then allocates the maximum of what it knows
and what the kernel knows. That way, the kernel doesn't need to
conditionalize its accesses to user space, and libc doesn't need to
conditionalize its accesses either.
-hpa
next prev parent reply other threads:[~2016-04-04 17:12 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-04 17:01 [RFC PATCH v6 0/5] Thread-local ABI system call (CPU number cache) Mathieu Desnoyers
2016-04-04 17:01 ` [RFC PATCH v6 1/5] Thread-local ABI system call: cache CPU number of running thread Mathieu Desnoyers
2016-04-04 17:11 ` H. Peter Anvin [this message]
2016-04-04 19:46 ` Mathieu Desnoyers
2016-04-04 20:48 ` Mathieu Desnoyers
2016-04-05 16:02 ` Florian Weimer
2016-04-05 16:47 ` Peter Zijlstra
2016-04-07 9:01 ` Florian Weimer
2016-04-07 10:31 ` Peter Zijlstra
2016-04-07 10:39 ` Florian Weimer
2016-04-07 11:19 ` Peter Zijlstra
2016-04-07 12:03 ` Florian Weimer
2016-04-07 12:25 ` Peter Zijlstra
2016-04-07 12:37 ` Florian Weimer
2016-04-07 15:59 ` Mathieu Desnoyers
2016-04-07 12:34 ` Mathieu Desnoyers
2016-04-07 16:39 ` Linus Torvalds
2016-04-07 16:46 ` Andy Lutomirski
2016-04-07 16:50 ` Florian Weimer
2016-04-07 16:59 ` Linus Torvalds
2016-04-07 16:52 ` Linus Torvalds
2016-04-07 18:43 ` Mathieu Desnoyers
2016-04-07 20:22 ` Andi Kleen
2016-04-07 20:55 ` Mathieu Desnoyers
2016-04-07 10:40 ` Florian Weimer
2016-04-04 17:01 ` [RFC PATCH v6 2/5] Thread-local ABI cpu_id: ARM resume notifier Mathieu Desnoyers
2016-04-04 17:01 ` [RFC PATCH v6 3/5] Thread-local ABI: wire up ARM system call Mathieu Desnoyers
2016-04-04 17:01 ` [RFC PATCH v6 4/5] Thread-local ABI cpu_id: x86 32/64 resume notifier Mathieu Desnoyers
2016-04-04 17:01 ` [RFC PATCH v6 5/5] Thread-local ABI: wire up x86 32/64 system call Mathieu Desnoyers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5702A037.60200@zytor.com \
--to=hpa@zytor.com \
--cc=ahh@google.com \
--cc=akpm@linux-foundation.org \
--cc=andi@firstfloor.org \
--cc=bmaurer@fb.com \
--cc=boqun.feng@gmail.com \
--cc=catalin.marinas@arm.com \
--cc=cl@linux.com \
--cc=davejwatson@fb.com \
--cc=josh@joshtriplett.org \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=luto@amacapital.net \
--cc=mathieu.desnoyers@efficios.com \
--cc=mingo@redhat.com \
--cc=mtk.manpages@gmail.com \
--cc=paulmck@linux.vnet.ibm.com \
--cc=peterz@infradead.org \
--cc=pjt@google.com \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).