Re: [PATCH 2/2] gpiolib: Defer gpio device setup until after gpiolib initialization

Linus Walleij
2016-04-01T08:16:33Z

On Fri, Apr 1, 2016 at 3:33 AM, Greg Ungerer <gregungerer@westnet.com.au> wrote:
> On 01/04/16 10:53, Guenter Roeck wrote:

>> Probably coldfire ?
>>
>> arch/m68k/coldfire/gpio.c:
>
> Yes, that is the one.
>
>> static struct bus_type mcfgpio_subsys = {
>> .name = "gpio",
>> .dev_name = "gpio",
>> };
>>
>> No idea what to do about that. Can that bus be renamed ?
>
> Yeah, it could. But is it even necessary at all now?
>
> I am thinking I could remove the subsys_system_register(&mcfgpio_subsys, NULL)
> call from that coldfire/gpio.c. Doing that certainly cleans up the
> boot. There was nothing much under the old coldfire /sys/gpio other than
> the standard devices/drivers/etc. And the new gpio api ofcourse has all
> that as well.

Please kill it if you can. Or are there userspaces for
coldfire that use this? In that case we need some compatibility
shim for them.

I'm trying to pull all needed functionality into the proper gpiolib
so we can get some order around the place...

Yours,
Linus Walleij