Re: [PATCH 2/2] gpiolib: Defer gpio device setup until after gpiolib initialization

Linus Walleij
2016-04-01T08:14:09Z

On Thu, Mar 31, 2016 at 5:11 PM, Guenter Roeck <linux@roeck-us.net> wrote:

> Since commit ff2b13592299 ("gpio: make the gpiochip a real device"),
> attempts to add a gpio chip prior to gpiolib initialization cause
> the system to crash. This happens because gpio_bus_type has not been
> registered yet. Defer creating gpio devices until after gpiolib has
> been initialized to fix the problem.
>
> Cc: Greg Ungerer <gerg@uclinux.org>
> Cc: Alexandre Courbot <gnurou@gmail.com>
> Fixes: ff2b13592299 ("gpio: make the gpiochip a real device")
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>

Very elegant solution and also a nice refactoring.

Patches applied for fixes and I'm pushing it for test so we get
some rotation in linux-next.

Yours,
Linus Walleij