From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755186AbcDEBr4 (ORCPT ); Mon, 4 Apr 2016 21:47:56 -0400 Received: from mailout3.w1.samsung.com ([210.118.77.13]:12915 "EHLO mailout3.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751318AbcDEBrx (ORCPT ); Mon, 4 Apr 2016 21:47:53 -0400 X-AuditID: cbfec7f5-f792a6d000001302-c1-5703193a26f9 Subject: Re: [RESEND PATCH] mfd: max77686: Use module_i2c_driver() instead of subsys initcall To: Javier Martinez Canillas , linux-kernel@vger.kernel.org References: <1459809962-8883-1-git-send-email-javier@osg.samsung.com> Cc: linux-samsung-soc@vger.kernel.org, Andi Shyti , Paul Gortmaker , Lee Jones , Laxman Dewangan From: Krzysztof Kozlowski Message-id: <57031935.7090006@samsung.com> Date: Tue, 05 Apr 2016 10:47:33 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-version: 1.0 In-reply-to: <1459809962-8883-1-git-send-email-javier@osg.samsung.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrELMWRmVeSWpSXmKPExsVy+t/xq7pWkszhBge3cltsP/KM1eLN2zVM Fq9fGFos3beaxeL+16OMFpd3zWGzmHF+H5PFtb3HmR04PO5c28Pm0dv8js1jS/9ddo++LasY PT5vkvNYv2UrUwBbFJdNSmpOZllqkb5dAlfGqpXT2Aoeclc0vL3P2sC4lrOLkZNDQsBEoufG CXYIW0ziwr31bF2MXBxCAksZJZqe7GCBcJ4ySky585sJpEpYIF7i5dTHjCC2iECoxL+Lt8Fs IQFXiY3/t7CC2MwCxxklejYpgNhsAsYSm5cvYQOxeQW0JF4eeAVUw8HBIqAqseitBUhYVCBC 4snck4wQJYISPybfYwGxOQXcJN7sXsoOUs4soCdx/6IWxHR5ic1r3jJPYBSYhaRjFkLVLCRV CxiZVzGKppYmFxQnpeca6RUn5haX5qXrJefnbmKEhPzXHYxLj1kdYhTgYFTi4Z35nilciDWx rLgy9xCjBAezkghvjBhzuBBvSmJlVWpRfnxRaU5q8SFGaQ4WJXHembvehwgJpCeWpGanphak FsFkmTg4pRoYRYJ/B7ry/VyowHPSN2X2EiV900u3rq5Pkf86a+aF7rOhqrW/bSLPPu5RFMzr VMrbvvueaJTB1vK2H94y04o3x/l8SVvFEBszJ3tet9T7wL8Oq9TLct/oLLGae2y6mcTvezp6 DuvLxUv/TCu194yIXV4UrLU595fCgXatOQy7r/+6ZD1R8fpOJZbijERDLeai4kQAV/ZSFXUC AAA= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05.04.2016 07:46, Javier Martinez Canillas wrote: > The driver's init and exit function don't do anything besides adding and > deleting the I2C driver so the module_i2c_driver() macro could be used. > > Currently is not being used because the driver is initialized at subsys > initcall level, claiming that this is done to allow consumers devices to > use the resources provided by this driver. But dependencies are in DT so > manual ordering of init calls is not necessary any more. > > Signed-off-by: Javier Martinez Canillas > > --- > > Changes in the resend: > - Change commit message to make clear that dependencies are in DT instead > giving the impression that it was wishful thinking (Krzysztof Kozlowski). > > Hello, > > This patch was first sent as a part of a bigger series to allow the > max77686 MFD driver to be built as a module [0]. The other patches > were already picked but $SUBJECT wasn't, probably because there was > a dependency with a patch on the exynos thermal driver [1]. > > But the exynos thermal patches also landed in mainline so I think it > should be safe to merged $SUBJECT now. > > [0]: https://lkml.org/lkml/2016/2/11/857 > [1]: https://lkml.org/lkml/2016/2/18/592 > > Best regards, > Javier > > drivers/mfd/max77686.c | 13 +------------ > 1 file changed, 1 insertion(+), 12 deletions(-) > Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof