From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757865AbcDEJ0z (ORCPT ); Tue, 5 Apr 2016 05:26:55 -0400 Received: from foss.arm.com ([217.140.101.70]:49872 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757524AbcDEJ0x (ORCPT ); Tue, 5 Apr 2016 05:26:53 -0400 Subject: Re: [PATCH] arm64: hw-breakpoint: Remove superfluous SMP function call To: Anna-Maria Gleixner , linux-kernel@vger.kernel.org References: <1459766569-17237-1-git-send-email-anna-maria@linutronix.de> Cc: rt@linutronix.de, Catalin Marinas , Will Deacon , linux-arm-kernel@lists.infradead.org From: "Suzuki K. Poulose" Message-ID: <570384DA.6010805@arm.com> Date: Tue, 5 Apr 2016 10:26:50 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <1459766569-17237-1-git-send-email-anna-maria@linutronix.de> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/04/16 11:42, Anna-Maria Gleixner wrote: > Since commit 1cf4f629d9d2 ("cpu/hotplug: Move online calls to > hotplugged cpu") it is ensured that callbacks of CPU_ONLINE and > CPU_DOWN_PREPARE are processed on the hotplugged cpu. Due to this SMP > function calls are no longer required. > > Replace smp_call_function_single() with a direct call of > hw_breakpoint_reset(). To keep the calling convention, interrupts are > explicitely disabled around the call. While you are at it, could you please also fix a similar instance in arch/arm64/kernel/debug-monitors.c: hw_breakpoint_reset_notify() ? Thanks Suzuki