From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Anna-Maria Gleixner <anna-maria@linutronix.de>,
linux-kernel@vger.kernel.org
Cc: Catalin Marinas <catalin.marinas@arm.com>,
linux-arm-kernel@lists.infradead.or, rt@linutronix.de,
Will Deacon <will.deacon@arm.com>
Subject: Re: [PATCH] arm64/debug: Remove superfluous SMP function call
Date: Tue, 5 Apr 2016 13:58:51 +0300 [thread overview]
Message-ID: <57039A6B.4080707@cogentembedded.com> (raw)
In-Reply-To: <1459766549-17189-1-git-send-email-anna-maria@linutronix.de>
Hello.
On 4/4/2016 1:42 PM, Anna-Maria Gleixner wrote:
> Since commit 1cf4f629d9d2 "cpu/hotplug: Move online calls to
> hotplugged cpu" it is ensured that callbacks of CPU_ONLINE and
scripts/checkpatch.pl now enforces commit citing certain style, yours
doesn't quite match it, also need parens around quotes enclosing the summary.
> CPU_DOWN_PREPARE are processed on the hotplugged cpu. Due to this SMP
> function calls are no longer required.
>
> Replace smp_call_function_single() with a direct call to
> clear_os_lock(). The function writes the OSLAR register to clear OS
> locking. This does not require to be called with interrupts disabled,
> therefore the smp_call_function_single() calling convention is not
> preserved.
>
> Cc: Catalin Marinas <catalin.marinas@arm.com>
> Cc: Will Deacon <will.deacon@arm.com>
> Cc: linux-arm-kernel@lists.infradead.or
> Signed-off-by: Anna-Maria Gleixner <anna-maria@linutronix.de>
[...]
MBR, Sergei
prev parent reply other threads:[~2016-04-05 10:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-04 10:42 [PATCH] arm64/debug: Remove superfluous SMP function call Anna-Maria Gleixner
2016-04-05 10:58 ` Sergei Shtylyov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57039A6B.4080707@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=anna-maria@linutronix.de \
--cc=catalin.marinas@arm.com \
--cc=linux-arm-kernel@lists.infradead.or \
--cc=linux-kernel@vger.kernel.org \
--cc=rt@linutronix.de \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox