From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757305AbcDEK64 (ORCPT ); Tue, 5 Apr 2016 06:58:56 -0400 Received: from mail-lf0-f48.google.com ([209.85.215.48]:34402 "EHLO mail-lf0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751433AbcDEK6z (ORCPT ); Tue, 5 Apr 2016 06:58:55 -0400 Subject: Re: [PATCH] arm64/debug: Remove superfluous SMP function call To: Anna-Maria Gleixner , linux-kernel@vger.kernel.org References: <1459766549-17189-1-git-send-email-anna-maria@linutronix.de> Cc: Catalin Marinas , linux-arm-kernel@lists.infradead.or, rt@linutronix.de, Will Deacon From: Sergei Shtylyov Message-ID: <57039A6B.4080707@cogentembedded.com> Date: Tue, 5 Apr 2016 13:58:51 +0300 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.7.1 MIME-Version: 1.0 In-Reply-To: <1459766549-17189-1-git-send-email-anna-maria@linutronix.de> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello. On 4/4/2016 1:42 PM, Anna-Maria Gleixner wrote: > Since commit 1cf4f629d9d2 "cpu/hotplug: Move online calls to > hotplugged cpu" it is ensured that callbacks of CPU_ONLINE and scripts/checkpatch.pl now enforces commit citing certain style, yours doesn't quite match it, also need parens around quotes enclosing the summary. > CPU_DOWN_PREPARE are processed on the hotplugged cpu. Due to this SMP > function calls are no longer required. > > Replace smp_call_function_single() with a direct call to > clear_os_lock(). The function writes the OSLAR register to clear OS > locking. This does not require to be called with interrupts disabled, > therefore the smp_call_function_single() calling convention is not > preserved. > > Cc: Catalin Marinas > Cc: Will Deacon > Cc: linux-arm-kernel@lists.infradead.or > Signed-off-by: Anna-Maria Gleixner [...] MBR, Sergei