From: Taeung Song <treeze.taeung@gmail.com>
To: Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com>
Cc: Vinson Lee <vlee@freedesktop.org>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>,
Josh Poimboeuf <jpoimboe@redhat.com>,
Alexei Starovoitov <ast@plumgrid.com>,
Wang Nan <wangnan0@huawei.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] perf config: Fix build with older toolchain.
Date: Tue, 5 Apr 2016 22:47:21 +0900 [thread overview]
Message-ID: <5703C1E9.8070000@gmail.com> (raw)
In-Reply-To: <20160405133819.GB5945@kernel.org>
Hi, Arnaldo
On 04/05/2016 10:38 PM, Arnaldo Carvalho de Melo wrote:
> Em Tue, Apr 05, 2016 at 02:24:19PM +0900, Taeung Song escreveu:
>> On 04/05/2016 07:07 AM, Vinson Lee wrote:
>>> if (!strcmp(var, "buildid.dir")) {
>>> - const char *dirname = perf_config_dirname(var, value);
>>> + const char *v = perf_config_dirname(var, value);
>>
>> Why you use 'v' variable name ?
>>
>> 'v' variable name was used in set_buildid_dir(), too.
>> But I send a patch renaming 'v' to 'home' because 'home' is more readable.
>> 37194f4 ("perf config: Rename 'v' to 'home' in set_buildid_dir()")
>> https://lkml.org/lkml/2016/3/27/98
>>
>> IMHO, I like using 'dir' instead of 'v'.
>
> Whatever, I'm switching this to 'dir', but don't pay _that_ much
> attention to variables that have such a narrow scope...
>
OK, I got it! :)
Thanks,
Taeung
next prev parent reply other threads:[~2016-04-05 13:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-04 22:07 [PATCH] perf config: Fix build with older toolchain Vinson Lee
2016-04-05 5:24 ` Taeung Song
2016-04-05 13:38 ` Arnaldo Carvalho de Melo
2016-04-05 13:47 ` Taeung Song [this message]
2016-04-05 13:36 ` Arnaldo Carvalho de Melo
2016-04-13 7:12 ` [tip:perf/core] " tip-bot for Vinson Lee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5703C1E9.8070000@gmail.com \
--to=treeze.taeung@gmail.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=arnaldo.melo@gmail.com \
--cc=ast@plumgrid.com \
--cc=jolsa@kernel.org \
--cc=jpoimboe@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=vlee@freedesktop.org \
--cc=wangnan0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox