From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758533AbcDEOYo (ORCPT ); Tue, 5 Apr 2016 10:24:44 -0400 Received: from lists.s-osg.org ([54.187.51.154]:33602 "EHLO lists.s-osg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758484AbcDEOYl (ORCPT ); Tue, 5 Apr 2016 10:24:41 -0400 Subject: Re: [PATCH 4/7] drivers/mfd: make max14577.c explicitly non-modular To: Krzysztof Kozlowski , Paul Gortmaker , linux-kernel@vger.kernel.org References: <1459718659-28316-1-git-send-email-paul.gortmaker@windriver.com> <1459718659-28316-5-git-send-email-paul.gortmaker@windriver.com> <5701E2AA.5070208@samsung.com> Cc: Chanwoo Choi , Samuel Ortiz , Lee Jones From: Javier Martinez Canillas Message-ID: <5703CAA0.2090001@osg.samsung.com> Date: Tue, 5 Apr 2016 10:24:32 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <5701E2AA.5070208@samsung.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Krzysztof, On 04/03/2016 11:42 PM, Krzysztof Kozlowski wrote: > On 04.04.2016 06:24, Paul Gortmaker wrote: >> The Kconfig currently controlling compilation of this code is: >> >> mfd/Kconfig:config MFD_MAX14577 >> mfd/Kconfig: bool "Maxim Semiconductor MAX14577/77836 MUIC + Charger Support" >> >> ...meaning that it currently is not being built as a module by anyone. >> >> Lets remove the modular code that is essentially orphaned, so that >> when reading the driver there is no doubt it is builtin-only. >> >> Since module_init was not in use by this code, the init ordering >> remains unchanged with this commit. >> >> Also note that MODULE_DEVICE_TABLE is a no-op for non-modular code. >> >> We also delete the MODULE_LICENSE tag etc. since all that information >> is already contained at the top of the file in the comments. >> >> Cc: Chanwoo Choi >> Cc: Krzysztof Kozlowski >> Cc: Samuel Ortiz >> Cc: Lee Jones >> Signed-off-by: Paul Gortmaker >> --- >> drivers/mfd/max14577.c | 13 +------------ >> 1 file changed, 1 insertion(+), 12 deletions(-) > > +Cc Javier, > > In general I agree with the patchset except maybe here because it > conflicts with Javier's work to make it a module: > mfd: max14577: Use module_init() instead of subsys_initcall() > http://www.spinics.net/lists/kernel/msg2213747.html > > Javier's patchset is however missing a tested-by tag so maybe this is > why it was not merged. > > Unfortunately I cannot provide testing because my current device with > max14577/max77836 is dead and its recovery is not easy. Maybe I will get > a proper device in a few weeks after going back to Poland. > > My proposal would be to wait with this max14577 change a little bit. > Chanwoo said he should be able to test: https://lkml.org/lkml/2016/3/18/78 So hopefully I should have some Tested-by tags for that series soon. > Best regards, > Krzysztof > Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America