From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758649AbcDERHh (ORCPT ); Tue, 5 Apr 2016 13:07:37 -0400 Received: from vern.gendns.com ([206.190.152.46]:55447 "EHLO vern.gendns.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753172AbcDERHf (ORCPT ); Tue, 5 Apr 2016 13:07:35 -0400 Subject: Re: [PATCH v3 0/5] davinci_mmc fixes To: Ulf Hansson References: <1458186341-6970-1-git-send-email-david@lechnology.com> <5703ECFE.6060706@lechnology.com> Cc: Sekhar Nori , Kevin Hilman , Russell King , Jaehoon Chung , Krzysztof Kozlowski , Peter Ujfalusi , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , linux-mmc From: David Lechner Message-ID: <5703F0DF.3020209@lechnology.com> Date: Tue, 5 Apr 2016 12:07:43 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <5703ECFE.6060706@lechnology.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - vern.gendns.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - lechnology.com X-Get-Message-Sender-Via: vern.gendns.com: authenticated_id: davidmain+lechnology.com/only user confirmed/virtual account not confirmed X-Authenticated-Sender: vern.gendns.com: davidmain@lechnology.com X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/05/2016 11:51 AM, David Lechner wrote: > On 04/05/2016 06:12 AM, Ulf Hansson wrote: >> >> Patch 3 triggers a compiler warning, please fix it. >> >> ../drivers/mmc/host/davinci_mmc.c: In function ‘davinci_mmcsd_probe’: >> ../drivers/mmc/host/davinci_mmc.c:1208:6: warning: ‘ret’ may be used >> uninitialized in this function [-Wmaybe-uninitialized] >> >> I have applied patch 1->2 for next, so no need to resend these. >> >> Kind regards >> Uffe >> > > I am not getting a compiler warning with this commit. Can you please > provide a git link so that I can be sure I am building using the same > branch that you are using? I think I figured it out. I am applying the patches on top of the next branch from git://git.linaro.org/people/ulf.hansson/mmc.git. However, I am still not getting a compiler warning. Perhaps it has to do with the gcc version. I'm not exactly sure how to fix it since it is really not used uninitialized. Just set it to 0 in the variable declaration?