From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933766AbcDEViF (ORCPT ); Tue, 5 Apr 2016 17:38:05 -0400 Received: from mail-wm0-f65.google.com ([74.125.82.65]:35363 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933750AbcDEViC (ORCPT ); Tue, 5 Apr 2016 17:38:02 -0400 Subject: Re: [PATCH 4/5] devicetree: leds: Introduce "panic-blink" optional property To: Ezequiel Garcia , linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <1459801326-5541-1-git-send-email-ezequiel@vanguardiasur.com.ar> <1459801326-5541-5-git-send-email-ezequiel@vanguardiasur.com.ar> Cc: Richard Purdie , Jacek Anaszewski , robh@kernel.org From: Jacek Anaszewski Message-ID: <5704301D.7040300@gmail.com> Date: Tue, 5 Apr 2016 23:37:33 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Icedove/38.7.0 MIME-Version: 1.0 In-Reply-To: <1459801326-5541-5-git-send-email-ezequiel@vanguardiasur.com.ar> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Ezequiel, On 04/04/2016 10:22 PM, Ezequiel Garcia wrote: > It's desirable to specify which LEDs are to be blinked on a kernel > panic. Therefore, introduce a devicetree boolean property to mark > which LEDs should be treated this way. > > Signed-off-by: Ezequiel Garcia > --- > Documentation/devicetree/bindings/leds/common.txt | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Documentation/devicetree/bindings/leds/common.txt b/Documentation/devicetree/bindings/leds/common.txt > index 68419843e32f..dd409df9203a 100644 > --- a/Documentation/devicetree/bindings/leds/common.txt > +++ b/Documentation/devicetree/bindings/leds/common.txt > @@ -37,6 +37,8 @@ Optional properties for child nodes: > property is mandatory for the LEDs in the non-flash modes > (e.g. torch or indicator). > > +- panic-blink : Mark this LED to be used by the panic LED trigger. I'd say that 'panic-indicator' would be more informative. Please next time cc also devicetree list and maintainers. > + > Required properties for flash LED child nodes: > - flash-max-microamp : Maximum flash LED supply current in microamperes. > - flash-max-timeout-us : Maximum timeout in microseconds after which the flash > -- Best regards, Jacek Anaszewski