Re: [PATCH v2 3/5] dmaengine: qcom: bam_dma: add controlled remotely dt property

Stanimir Varbanov
2016-04-06T15:05:26Z

On 04/06/2016 02:44 AM, Vinod Koul wrote:
> On Wed, Apr 06, 2016 at 01:56:20AM +0300, Stanimir Varbanov wrote:
>> Documentation/devicetree/bindings/dma/qcom_bam_dma.txt | 2 ++
>> drivers/dma/qcom/bam_dma.c | 7 +++++++
>
> The binding should be a separate patch..

I'm not sure, isn't this rule valid only when we introduce the binding
document? But if you insist I can make a separate patch.

>
>>
>> + bdev->controlled_remotely = of_property_read_bool(pdev->dev.of_node,
>> + "qcom,controlled-remotely");
>> +
>
> we need some defaults here, how will this work with boards withe older DT.
>

if the introduced property missing from DT node the driver behavior is
preserved.

--
regards,
Stan