Re: [PATCH v2 3/5] dmaengine: qcom: bam_dma: add controlled remotely dt property

Rob Herring
2016-04-07T17:58:10Z

On Wed, Apr 06, 2016 at 01:56:20AM +0300, Stanimir Varbanov wrote:
> Some of the peripherals has bam which is controlled by remote
> processor, thus the bam dma driver must avoid register writes
> which initialise bam hw block. Those registers are protected
> from xPU block and any writes to them will lead to secure
> violation and system reboot.
>
> Adding the contolled_remotely flag in bam driver to avoid
> not permitted register writes in bam_init function.
>
> Signed-off-by: Stanimir Varbanov <stanimir.varbanov@linaro.org>
> Reviewed-by: Andy Gross <andy.gross@linaro.org>
> ---
> Documentation/devicetree/bindings/dma/qcom_bam_dma.txt | 2 ++
> drivers/dma/qcom/bam_dma.c | 7 +++++++
> 2 files changed, 9 insertions(+)

Acked-by: Rob Herring <robh@kernel.org>

On being a separate patch, yes that is always the preference. However,
this change is so small it doesn't matter to me. But this is going in
thru Vinod's tree, so it is his call.

Rob