From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754977AbcDGD4B (ORCPT <rfc822;w@1wt.eu>);
	Wed, 6 Apr 2016 23:56:01 -0400
Received: from mail-pf0-f196.google.com ([209.85.192.196]:35354 "EHLO
	mail-pf0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752967AbcDGDz7 (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 6 Apr 2016 23:55:59 -0400
Subject: Re: [PATCH v2 09/30] Add tile-specific parity functions
To: Chris Metcalf <cmetcalf@mellanox.com>, zengzhaoxiu@163.com
References: <57031D9D.801@gmail.com>
 <1459933716-6990-1-git-send-email-zengzhaoxiu@163.com>
 <57050EC5.3090604@mellanox.com>
Cc: linux-kernel@vger.kernel.org
From: Zeng Zhaoxiu <zhaoxiu.zeng@gmail.com>
Message-ID: <5705DA4B.4040805@gmail.com>
Date: Thu, 7 Apr 2016 11:55:55 +0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.6.0
MIME-Version: 1.0
In-Reply-To: <57050EC5.3090604@mellanox.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

在 2016年04月06日 21:27, Chris Metcalf 写道:
> On 4/6/2016 5:08 AM, zengzhaoxiu@163.com wrote:
>> From: Zhaoxiu Zeng<zhaoxiu.zeng@gmail.com>
>>
>> Signed-off-by: Zhaoxiu Zeng<zhaoxiu.zeng@gmail.com>
>> ---
>>   arch/tile/include/asm/bitops.h | 26 ++++++++++++++++++++++++++
>>   1 file changed, 26 insertions(+)
>
> Since all the code you are adding here is architecture-independent,
> I think it would make more sense to have it be in a file like
> include/asm-generic/bitops/parity-popcount.h, which can then
> be included from arch/tile/include/asm/bitops.h.
>

Agreed, thanks!