From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757849AbcDGWFY (ORCPT ); Thu, 7 Apr 2016 18:05:24 -0400 Received: from mail-qg0-f41.google.com ([209.85.192.41]:35683 "EHLO mail-qg0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752898AbcDGWFX (ORCPT ); Thu, 7 Apr 2016 18:05:23 -0400 Subject: Re: [PATCH] staging: android: ion: dummy: fix dereference of ERR_PTR To: Sudip Mukherjee , Greg Kroah-Hartman , =?UTF-8?Q?Arve_Hj=c3=b8nnev=c3=a5g?= , Riley Andrews References: <1460046745-30345-1-git-send-email-sudipm.mukherjee@gmail.com> Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org From: Laura Abbott Message-ID: <5706D99D.6000009@redhat.com> Date: Thu, 7 Apr 2016 15:05:17 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.1 MIME-Version: 1.0 In-Reply-To: <1460046745-30345-1-git-send-email-sudipm.mukherjee@gmail.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/07/2016 09:32 AM, Sudip Mukherjee wrote: > ion_device_create() can fail and if it fails then it returns the error > value in ERR_PTR. > Reviewed-by: Laura Abbott > Signed-off-by: Sudip Mukherjee > --- > drivers/staging/android/ion/ion_dummy_driver.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/staging/android/ion/ion_dummy_driver.c b/drivers/staging/android/ion/ion_dummy_driver.c > index 5678870..806e76b 100644 > --- a/drivers/staging/android/ion/ion_dummy_driver.c > +++ b/drivers/staging/android/ion/ion_dummy_driver.c > @@ -68,6 +68,8 @@ static int __init ion_dummy_init(void) > int i, err; > > idev = ion_device_create(NULL); > + if (IS_ERR(idev)) > + return PTR_ERR(idev); > heaps = kcalloc(dummy_ion_pdata.nr, sizeof(struct ion_heap *), > GFP_KERNEL); > if (!heaps) >