From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758151AbcDHN5p (ORCPT ); Fri, 8 Apr 2016 09:57:45 -0400 Received: from mail-wm0-f49.google.com ([74.125.82.49]:36574 "EHLO mail-wm0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756017AbcDHN5n (ORCPT ); Fri, 8 Apr 2016 09:57:43 -0400 Subject: Re: [PATCH] phy: phy-mt65xx-usb3: add support for mt2701 platform To: Chunfeng Yun , Kishon Vijay Abraham I References: <1460106832-25360-1-git-send-email-chunfeng.yun@mediatek.com> Cc: linux-usb@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org From: Matthias Brugger Message-ID: <5707B8D3.4070605@gmail.com> Date: Fri, 8 Apr 2016 15:57:39 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.0 MIME-Version: 1.0 In-Reply-To: <1460106832-25360-1-git-send-email-chunfeng.yun@mediatek.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/04/16 11:13, Chunfeng Yun wrote: > A new compatible string, "mediatek,mt2701-u3phy", is added. > > Some register settings to avoid RX sensitivity level degradation > which may arise on mt8173 platform are separated from other > platforms. > > Signed-off-by: Chunfeng Yun > --- > .../devicetree/bindings/phy/phy-mt65xx-usb.txt | 4 +- > drivers/phy/Kconfig | 5 +- > drivers/phy/phy-mt65xx-usb3.c | 77 +++++++++++++------- > 3 files changed, 57 insertions(+), 29 deletions(-) > > diff --git a/Documentation/devicetree/bindings/phy/phy-mt65xx-usb.txt b/Documentation/devicetree/bindings/phy/phy-mt65xx-usb.txt > index 00100cf..8d2a62f 100644 > --- a/Documentation/devicetree/bindings/phy/phy-mt65xx-usb.txt > +++ b/Documentation/devicetree/bindings/phy/phy-mt65xx-usb.txt > @@ -4,7 +4,9 @@ mt65xx USB3.0 PHY binding > This binding describes a usb3.0 phy for mt65xx platforms of Medaitek SoC. > > Required properties (controller (parent) node): > - - compatible : should be "mediatek,mt8173-u3phy" > + - compatible : should be one or more of If there are more then one, which value will avoid_rx_sen_degradation have? There should be only one compatible. Apart from that normally the dts documentation parts are separate patches. Regards, Matthias