From: Denys Vlasenko <dvlasenk@redhat.com>
To: Bob Peterson <rpeterso@redhat.com>
Cc: Steven Whitehouse <swhiteho@redhat.com>,
cluster-devel@redhat.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fs/gfs2/glock.c: Deinline do_error, save 1856 bytes
Date: Fri, 08 Apr 2016 21:46:08 +0200 [thread overview]
Message-ID: <57080A80.3090201@redhat.com> (raw)
In-Reply-To: <1824612152.49246801.1460143078420.JavaMail.zimbra@redhat.com>
On 04/08/2016 09:17 PM, Bob Peterson wrote:
> ----- Original Message -----
>> This function compiles to 522 bytes of machine code.
>>
> Is there a reason why you want to trade memory for speed? Are you
> optimizing for memory on an embedded device or something?
Yes. I did a scan for really large inlines and this function came up.
If you feel it is indeed performance critical, please ignore my patch.
next prev parent reply other threads:[~2016-04-08 19:46 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-08 18:58 [PATCH] drivers/infiniband/hw/nes/nes_verbs.c: Deinline nes_free_qp_mem, save 1072 bytes Denys Vlasenko
2016-04-08 18:58 ` [PATCH] drivers/scsi/fnic/fnic_scsi.c: Deinline fnic_queue_abort_io_req, save 1792 bytes Denys Vlasenko
2016-04-08 19:08 ` Laurence Oberman
2016-04-12 2:16 ` Martin K. Petersen
2016-04-08 18:58 ` [PATCH] drivers/virtio/virtio_ring.c: Deinline virtqueue_add, save 1016 bytes Denys Vlasenko
2016-04-09 20:14 ` Michael S. Tsirkin
2016-04-08 18:58 ` [PATCH] fs/gfs2/glock.c: Deinline do_error, save 1856 bytes Denys Vlasenko
2016-04-08 19:17 ` Bob Peterson
2016-04-08 19:46 ` Denys Vlasenko [this message]
2016-04-12 16:49 ` Bob Peterson
2016-04-08 18:58 ` [PATCH] lockdep: Deinline register_lock_class, save 2328 bytes Denys Vlasenko
2016-04-13 11:28 ` [tip:locking/core] locking/lockdep: Deinline register_lock_class(), " tip-bot for Denys Vlasenko
2016-04-11 4:41 ` [PATCH] drivers/infiniband/hw/nes/nes_verbs.c: Deinline nes_free_qp_mem, save 1072 bytes Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57080A80.3090201@redhat.com \
--to=dvlasenk@redhat.com \
--cc=cluster-devel@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rpeterso@redhat.com \
--cc=swhiteho@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox