[PATCH 1/2] tty: Remove unused TTY_NUMBER() macro

[PATCH 1/2] tty: Remove unused TTY_NUMBER() macro

[Peter Hurley]

TTY_NUMBER() has been unused since v2.5.71; removed by
"[PATCH] callout removal: callout is gone".

Signed-off-by: Peter Hurley <peter@hurleysoftware.com>
---
 drivers/tty/tty_io.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/tty/tty_io.c b/drivers/tty/tty_io.c
index 320dc4d..3cdd63b 100644
--- a/drivers/tty/tty_io.c
+++ b/drivers/tty/tty_io.c
@@ -230,9 +230,6 @@ static void tty_del_file(struct file *file)
 	tty_free_file(file);
 }
 
-
-#define TTY_NUMBER(tty) ((tty)->index + (tty)->driver->name_base)
-
 /**
  *	tty_name	-	return tty naming
  *	@tty: tty structure
-- 
2.8.1

[PATCH 2/2] tty: Remove stale parameter comment

[Peter Hurley]

noctty was removed as a parameter by commit 216513411937586
("tty: Consolidate noctty check in tty_open()").

Signed-off-by: Peter Hurley <peter@hurleysoftware.com>
---
 drivers/tty/tty_io.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/tty/tty_io.c b/drivers/tty/tty_io.c
index 3cdd63b..50979be 100644
--- a/drivers/tty/tty_io.c
+++ b/drivers/tty/tty_io.c
@@ -1960,7 +1960,6 @@ static struct tty_struct *tty_open_current_tty(dev_t device, struct file *filp)
  *	tty_lookup_driver - lookup a tty driver for a given device file
  *	@device: device number
  *	@filp: file pointer to tty
- *	@noctty: set if the device should not become a controlling tty
  *	@index: index for the device in the @return driver
  *	@return: driver for this inode (with increased refcount)
  *
-- 
2.8.1

Re: [PATCH 2/2] tty: Remove stale parameter comment

[Jiri Slaby]

On 04/10/2016, 05:36 AM, Peter Hurley wrote:
> noctty was removed as a parameter by commit 216513411937586

It is actually 11e1d4aa4da.

> ("tty: Consolidate noctty check in tty_open()").
> 
> Signed-off-by: Peter Hurley <peter@hurleysoftware.com>
> ---
>  drivers/tty/tty_io.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/tty/tty_io.c b/drivers/tty/tty_io.c
> index 3cdd63b..50979be 100644
> --- a/drivers/tty/tty_io.c
> +++ b/drivers/tty/tty_io.c
> @@ -1960,7 +1960,6 @@ static struct tty_struct *tty_open_current_tty(dev_t device, struct file *filp)
>   *	tty_lookup_driver - lookup a tty driver for a given device file
>   *	@device: device number
>   *	@filp: file pointer to tty
> - *	@noctty: set if the device should not become a controlling tty
>   *	@index: index for the device in the @return driver
>   *	@return: driver for this inode (with increased refcount)
>   *
> 


-- 
js
suse labs

Re: [PATCH 2/2] tty: Remove stale parameter comment

[Peter Hurley]

On 04/10/2016 01:24 AM, Jiri Slaby wrote:
> On 04/10/2016, 05:36 AM, Peter Hurley wrote:
>> noctty was removed as a parameter by commit 216513411937586
> 
> It is actually 11e1d4aa4da.

Right; not sure where that number came from.


> 
>> ("tty: Consolidate noctty check in tty_open()").
>>
>> Signed-off-by: Peter Hurley <peter@hurleysoftware.com>
>> ---
>>  drivers/tty/tty_io.c | 1 -
>>  1 file changed, 1 deletion(-)
>>
>> diff --git a/drivers/tty/tty_io.c b/drivers/tty/tty_io.c
>> index 3cdd63b..50979be 100644
>> --- a/drivers/tty/tty_io.c
>> +++ b/drivers/tty/tty_io.c
>> @@ -1960,7 +1960,6 @@ static struct tty_struct *tty_open_current_tty(dev_t device, struct file *filp)
>>   *	tty_lookup_driver - lookup a tty driver for a given device file
>>   *	@device: device number
>>   *	@filp: file pointer to tty
>> - *	@noctty: set if the device should not become a controlling tty
>>   *	@index: index for the device in the @return driver
>>   *	@return: driver for this inode (with increased refcount)
>>   *
>>
> 
>