From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751598AbcDKBGP (ORCPT ); Sun, 10 Apr 2016 21:06:15 -0400 Received: from szxga02-in.huawei.com ([119.145.14.65]:47237 "EHLO szxga02-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750982AbcDKBGO (ORCPT ); Sun, 10 Apr 2016 21:06:14 -0400 Subject: Re: [PATCH] irqchip/mbigen: Display message of MBIGEN domain created To: Marc Zyngier References: <1460099762-51497-1-git-send-email-wangkefeng.wang@huawei.com> <20160408090935.4ec95aa8@arm.com> <57076B2D.8050006@huawei.com> <20160408095325.49aaf6b0@arm.com> <570788E3.3080901@huawei.com> <57078BE8.8040604@arm.com> CC: Jason Cooper , , , , From: Kefeng Wang Message-ID: <570AF81D.90302@huawei.com> Date: Mon, 11 Apr 2016 09:04:29 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <57078BE8.8040604@arm.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.177.19.180] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A020206.570AF82A.0101,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2013-06-18 04:22:30, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: 6ac5b7721a01b96d6c34644a42a2321e Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2016/4/8 18:46, Marc Zyngier wrote: > On 08/04/16 11:33, Kefeng Wang wrote: >> >> >> On 2016/4/8 16:53, Marc Zyngier wrote: >>> On Fri, 8 Apr 2016 16:26:21 +0800 >>> Kefeng Wang wrote: >> [...] >> But there is still one issue in the for_each_child_of_node loop of >> mbigen_device_probe. Assume that there are 3+ child node(mbigen_gmac, >> mbigen_i2c, mbigen_xxx, etc) in mbigen_chip_dsa, if one of them with >> incorrect configuration, then the loop will end, but we still need >> parse the left child node. we should consider this situation, right? > > That's up to whoever designed the driver to decide, really. I don't know > if it is worth continuing in that case (and you are in a better position > than me to find out). Ok, will talk with Ma Jun directly, and if the change is needed, I will send a new patch after reviewed by Ma Jun. Thanks, Kefeng