From: Jan Kiszka <jan.kiszka@siemens.com>
To: Thierry Reding <thierry.reding@gmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scripts/gdb: Use $(abspath ...) instead of $(shell cd ... && pwd)
Date: Sun, 10 Apr 2016 21:04:48 -0700 [thread overview]
Message-ID: <570B2260.90704@siemens.com> (raw)
In-Reply-To: <1460106992-6864-1-git-send-email-thierry.reding@gmail.com>
On 2016-04-08 02:16, Thierry Reding wrote:
> From: Thierry Reding <treding@nvidia.com>
>
> Avoid forking off a shell to resolve the absolute path of the output
> directory when make's builtin $(abspath ...) function will do an
> adequate job.
>
> Signed-off-by: Thierry Reding <treding@nvidia.com>
> ---
> scripts/gdb/linux/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/gdb/linux/Makefile b/scripts/gdb/linux/Makefile
> index 6cf1ecf61057..d8b88e22e16a 100644
> --- a/scripts/gdb/linux/Makefile
> +++ b/scripts/gdb/linux/Makefile
> @@ -1,6 +1,6 @@
> always := gdb-scripts
>
> -SRCTREE := $(shell cd $(srctree) && /bin/pwd)
> +SRCTREE := $(abspath $(srctree))
>
> $(obj)/gdb-scripts:
> ifneq ($(KBUILD_SRC),)
>
Thanks, good cleanup. Queued.
Jan
--
Siemens AG, Corporate Technology, CT RDA ITP SES-DE
Corporate Competence Center Embedded Linux
next prev parent reply other threads:[~2016-04-11 4:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-08 9:16 [PATCH] scripts/gdb: Use $(abspath ...) instead of $(shell cd ... && pwd) Thierry Reding
2016-04-11 4:04 ` Jan Kiszka [this message]
2016-04-18 15:33 ` Thierry Reding
2016-04-18 15:51 ` Jan Kiszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=570B2260.90704@siemens.com \
--to=jan.kiszka@siemens.com \
--cc=linux-kernel@vger.kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox