From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932151AbcDKNKE (ORCPT ); Mon, 11 Apr 2016 09:10:04 -0400 Received: from bear.ext.ti.com ([192.94.94.41]:49620 "EHLO bear.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932071AbcDKNKB (ORCPT ); Mon, 11 Apr 2016 09:10:01 -0400 Subject: Re: [PATCH v6 04/10] usb: dwc3: omap: fix up error path on probe() To: Felipe Balbi References: <1460374506-9779-1-git-send-email-rogerq@ti.com> <1460374506-9779-5-git-send-email-rogerq@ti.com> <87bn5gnxp9.fsf@intel.com> CC: , , , , , , , , , , From: Roger Quadros Message-ID: <570BA219.3000606@ti.com> Date: Mon, 11 Apr 2016 16:09:45 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <87bn5gnxp9.fsf@intel.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/04/16 15:20, Felipe Balbi wrote: > > Hi, > > Roger Quadros writes: >> From: Felipe Balbi >> >> Even if pm_runtime_get*() fails, we *MUST* call >> pm_runtime_put_sync() before disabling PM. >> >> While at it, remove superfluous dwc3_omap_disable_irqs() >> in error path. >> >> Signed-off-by: Felipe Balbi >> [nsekhar@ti.com: patch description updates] >> Signed-off-by: Sekhar Nori >> Signed-off-by: Roger Quadros > > this fix is unrelated to DRD/OTG work, right ? Care to rebase only this > patch on v4.6-rc3 so I can apply it during current -rc ? > Sure, will do that. cheers, -roger