From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755011AbcDKNxK (ORCPT ); Mon, 11 Apr 2016 09:53:10 -0400 Received: from mail-bn1bon0096.outbound.protection.outlook.com ([157.56.111.96]:48736 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754473AbcDKNxE (ORCPT ); Mon, 11 Apr 2016 09:53:04 -0400 Authentication-Results: vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=none action=none header.from=amd.com; Subject: Re: [RFT v2] iommu/amd: use subsys_initcall() on amdv2 iommu To: Oded Gabbay References: <20160316171719.GE2195@8bytes.org> <1459273313-5139-1-git-send-email-mcgrof@kernel.org> <570BA694.8040900@amd.com> CC: "Luis R. Rodriguez" , Joerg Roedel , , "linux-kernel@vger.kernel.org" From: =?UTF-8?Q?Christian_K=c3=b6nig?= Message-ID: <570BAC2B.4090508@amd.com> Date: Mon, 11 Apr 2016 15:52:43 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [2a02:908:1250:ae81:e81b:ad8c:4800:115c] X-ClientProxiedBy: AM3PR08CA0039.eurprd08.prod.outlook.com (10.160.207.177) To SN1PR12MB0144.namprd12.prod.outlook.com (10.162.3.143) X-MS-Office365-Filtering-Correlation-Id: 7d469e93-18ae-4e34-bf26-08d362109606 X-Microsoft-Exchange-Diagnostics: 1;SN1PR12MB0144;2:Meeyk69Wu10Pz6trIW43F9Sg94Pqcz8bcC06qw6+OX1lGWbvdedNjHO/u44J6C44o5o4dSei5QPHJ19r84k+hvTohOZIVkQQnF4j0iuyWIASwBdF6L1+CXl7oflDZjqKSjQvnJ5Qq+iBc7v8WG7m6nLgw2NH293cML4m0/EVzj4zJ6pZHimWa5wtRr+bSeBL;3:ItwL3j40BhFrTA5mupnKXhoM/MvXVpSbLaDM9rusAD7dK/VgDnx8UAwPJitp0doi8L2NsNWX6Pz0wBYSEbwLx+YzEwSPaYKZ+5X6jButU9cLhZKvT0YdIQcN+AUpyWkj;25:ZnqtkeAgEFf6wGw38uUQgpuymg5FBRc6U/YQ8yyYzRkdL1TWJwyjgqxxVtr7Ii4Rqohnzu6cWD9SJyxVDEmy89Hp8hy/xnTC8hs1ogWYQoGn0ZZ7l6bgWVA0oDVMmH/D/nGW6jxFVtgtCRIFtad4kss1wl0llU6DQvbxy2Rw60f4t1sqtkEH+xIuXCm6kWiD5FEXYca08FHKAMCZdeg50fS6ner5k8NML1DuvFF7RePMsaDvdnVZSV/F+eHiTSz9Vczt04+FUpUQvkaVH7OElzxBkJh05pm83dXZKL4micj0P7Pv3e7MKkQC8GoGOQaVu3sUdc0iEjbv2rxrQLC/PQ== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:SN1PR12MB0144; X-Microsoft-Exchange-Diagnostics: 1;SN1PR12MB0144;20:FEVOk6MhI/7F10KT50IylXvxBZoE2YZ8mLnOUZ8c7SvtZ0i7vDpsIvE+g/nJDzkWbBMmyYtwRsLf7VMIVuT2S0wt75au0gFrv1qDQJdA5bsHiRsjxgYEml9Twpx5QzvN/dxfPChdUFmqEDHb6nnbbEp6BLL+1SArTz7HkWsFJg8nQ5NZVNdHoH1BYLl9wUX9yT0xhzeO48eIj7neKqY9EMpZVdpWrz75pQdXtSmk1sWR3Xb1l0KFTzUKLU0xObIjXgF8SNJWt5fKEpro2eH8NsD+Zd1NODA1eM4biMwo6Gq5aljwMRYSxpPlXl1RDmYpeT6tckmQQ23sg2mTFSNmnE+z1DE2u3+J3EC8It0tLNH1HLE+cXCOhQ2cdb2bGVJddNXTZRDUMtIkPVNmLz/JdAjgOs/S23LilSzgpv/NRCSTcgeQkTuVbNSC0nL5cS1gAeeOuCZ+MaISvhizcOHomaEkMvceLIsWKdTH8cDk1qUmXLa8chVuZrVsyozUgmN9;4:gDSpV+ZpV8NSnopmbEaPUcP9ArdKE/GYVJPj0+LXPkF9e0897WLj1c3Rjj1xPwxduiKkiM/MSRkV4bTJ0TyL1DNkz4JUKBqY4opWGCRwDO+bpPvS22T6TBpDQRwu4McCwvKLrz9XpPAQDHffT1AJl2THqsDjrgu6tQYp3AKmDkD8GhDRi6CklUQooYbLX5vYjs4NBWT+rX3p/mZeD7VyL9Jf/nyyLUOddGawcosgRh3J3S6zobZIyVS0eOAQnjC7jV0rzeI+gFLEB16ZdvRdKLwwsWEEYY14ITPlRx6S91TgHGpSb9jNw9Q+pV7McsmIQAPIL8zxzSntqizfniuCQJDsJxvh9LvupuV2frCWvwSpjNy2Tmnx5zQk60cfiUou X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(5005006)(8121501046)(10201501046)(3002001);SRVR:SN1PR12MB0144;BCL:0;PCL:0;RULEID:;SRVR:SN1PR12MB0144; X-Forefront-PRVS: 09090B6B69 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6009001)(377454003)(51694002)(24454002)(65956001)(65806001)(5004730100002)(1096002)(6116002)(23676002)(50466002)(54356999)(87266999)(47776003)(83506001)(19580405001)(19580395003)(80316001)(92566002)(77096005)(4326007)(64126003)(5008740100001)(189998001)(33656002)(86362001)(93886004)(76176999)(50986999)(2906002)(2870700001)(586003)(65816999)(4001350100001)(2950100001)(36756003)(81166005)(42186005)(110136002)(3826002);DIR:OUT;SFP:1101;SCL:1;SRVR:SN1PR12MB0144;H:[IPv6:2a02:908:1250:ae81:e81b:ad8c:4800:115c];FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtTTjFQUjEyTUIwMTQ0OzIzOktoNmR3TjNPVlNLWFpOK1ltZ2tKeHQ4NzV1?= =?utf-8?B?anJwMUZlbm0yV01HclRUVUg0UG43KzBhN0J3czhyV2xaOHFjK1gyeFVBZ1JL?= =?utf-8?B?TnVmR1F5aW1hNmhodlBSbzFuK1lGR3ByL0VFTkVFNndndWYvME9HRkRneDM3?= =?utf-8?B?UzhKSWgvZmwzZVY2N3dHUnN3T3JGSzlrMlZTdDdKUmNyOGhVaHJtODF4RlNm?= =?utf-8?B?MDkzVE41UkJOUlM2eUhoZjBuTjdqa2QvUmh3bFVqaXJQa2dhZGpyVG55SlNX?= =?utf-8?B?RUZtK0ZlV0gxV2hJa0g0RGl2My9VelNjeUlWbG9ja0k5SEc3UjZhOXNuTGkv?= =?utf-8?B?MWd1Qk1FUGI1cE1XL0xMQ3p6cjl6aDlhMHlQUnhCcmU3TlBnUlVjeHFMM2l1?= =?utf-8?B?NWpneFlNT214a1hvbGJEdC94NGhVTy9FcFdSeHdCQUVVVVZlaDRzb3lvT3VP?= =?utf-8?B?NzlCbUxmOVhJUnV0alhLczFlYjNEZXZMM2Y3NDNtQkJIUnBnNUdZOEJoQ0Rr?= =?utf-8?B?SGthQ0hnYU5adVJXUTRCeTlINHJzTUxJcWgyTjFqT2x5b25hWVVjNXdEM1Y0?= =?utf-8?B?UW05MXRUKzFaa29vcVNCQmtVYTFZZDRrSFR1ekF0Vk9Ud05meWp5azU1d2Iw?= =?utf-8?B?YUFXYnZSMkJLZzU3ZFdCdEdoTDc0eWwvNUFyeW9NOWZTOXlNTWNlcjlaSGUr?= =?utf-8?B?aUNoS2sxWjM4N1I0THJqSG9Ncm1aRFpPRU13RzRsdWoyaXdJRjJ6bnE2QmJG?= =?utf-8?B?QmVxYUVabGRKR28relZQUUVnQXNTMWdscHgvdjhycXplQlorMkY1L0lvNmRv?= =?utf-8?B?a2phV1NIdFR3eVhyTkRBTk9TbUpKZGxDSVgyNUNhM290ZkxtVGNEVlIwcnpj?= =?utf-8?B?WkcyV05icklNRTR2bEc0RmFETWFkbjUzckJlSi9OSDNGOEVYUVpGbjVGNXVj?= =?utf-8?B?VUNuZkZ1NldET0plV1dSdlVJM3FPNzRLU3V0R3FkeldhRXJnL213MENrQ01U?= =?utf-8?B?ZkxxSUZpa2I1WnlBYlJCYVczdHVkUGo2WWlwZFk0Ti9tWkRKek1RU3RiZndJ?= =?utf-8?B?bHRWckwzTEJyY3VZUGZRZG02a2E3SU1Ia1dZTmhraWFCMGRCUkpRd3o1M1dT?= =?utf-8?B?dFh2bGhubEdpUlBoMklpZW9iZnk2NFZmQWxPWjdXYndEN3c0K09WZ3JHSytv?= =?utf-8?B?cWRFdFcrQVZwUWdTRUpjK0lscGQ1NDdlWFh6Q09GNVREMWZlQUJKRS9QaDFO?= =?utf-8?B?dmg0WUJTRFQwNVB2cVhCcytUeFRZR2RLNURhSXgvQVBnbmltUzBkVVl0aDJ1?= =?utf-8?B?MGlXMjIxMjRDOHQ0d3dFOEtuZlM2RXhsMjR6akI1SUZaa1VOWFhTK3k1TGEy?= =?utf-8?B?NjRhM0lzZVBySHJodk9PMkplKzFtU0NoejZNVm5RNDF2UGNYc1ZwY1NnUCtw?= =?utf-8?B?OFRLU09TNHJKai8wanBtM3RYTStMTjAzTngxZnBLRWlkVEtKTEh3S1dVU1Q1?= =?utf-8?B?SzNiZz09?= X-Microsoft-Exchange-Diagnostics: 1;SN1PR12MB0144;5:yaIychGrnGjKkh65kFHX6DqsclvqtAsFKg2EKRt/NcDM/rf47Ru29xWfIY0RWDbJ2WPpADfZN4aRes8e340c1R5gepQCNQoapzgYOfDfUIjBnXVcGAW2ldUZSFRfMf/t0ydgljPVnoMFnwY7uRLkjw==;24:GOZwBes+XKSIHaSf2SlK/Uj5gP4jK27ZafNir+5scbQF7AjVJHxanjd5PfBpfhCu44yAIpRmA+Spu3dRZ8Rk4rz1ql0OOcNBL4rnGOVxNcM=;20:tr0ctjjvh0pJTbZsFamCNRMSzoOCJgbNOClkaz9X/Yjrimd8b12HHivvXQZMbCBTw7kUmSF9nc2POVzJNGXmRo47sEshQhJZA7pKGW9TWGA4Q8sW2hqJvsQssYygZoo2SgOy2DZ3ABtIzPq6WtJ/Wdy93DdiypyPghgjhSg0TxtgeFhUr4nElEAY8uNdMH2/J13B1DRrDEo5vgi/y4znkqdFKtjRBgo3XQG+Nhm91U58cGJKMi5qci0P3acSeNLR SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Apr 2016 13:52:55.6020 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN1PR12MB0144 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am 11.04.2016 um 15:39 schrieb Oded Gabbay: > On Mon, Apr 11, 2016 at 4:28 PM, Christian König > wrote: >> Am 09.04.2016 um 02:25 schrieb Luis R. Rodriguez: >>> On Tue, Mar 29, 2016 at 10:41 AM, Luis R. Rodriguez wrote: >>>> We need to ensure amd iommu v2 initializes before >>>> driver uses such as drivers/gpu/drm/amd/amdkfd/kfd_module.c, >>>> to do this make its init routine a subsys_initcall() which >>>> ensures its load init is called first than modules when >>>> built-in. >>>> >>>> This reverts the old work around implemented through commit >>>> 1bacc894c227fad8a7 ("drivers: Move iommu/ before gpu/ in Makefile"), >>>> instead of making the dependency implicit by linker order this >>>> makes the ordering requirement explicit through proper kernel >>>> APIs. >>>> >>>> Cc: Oded Gabbay >>>> Cc: Christian König >>>> Signed-off-by: Luis R. Rodriguez >> >> Sorry for not responding earlier. Just coming back to all the stuff on my TODO list. >> >> Patch is Acked-by: Christian König > > Christian, > Just wanted to be sure if you tested this patch-set or not. I did NOT tested it. If AMD IOMMU requires something which will now initialize after the IOMMU module we will obviously run into trouble again. I assumed that the creator of the patch did some testing. > > I don't think it should be merged without testing. If you already > tested it than fine. If not, I think I can do it in the next week or > so (just came back from PTO). Yeah, agree totally. Regards, Christian. > > Oded > >> >> Regards, >> Christian. >> >>> *poke* >>> >>> Luis >>