From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933454AbcDKNxi (ORCPT ); Mon, 11 Apr 2016 09:53:38 -0400 Received: from devils.ext.ti.com ([198.47.26.153]:49138 "EHLO devils.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933057AbcDKNxd (ORCPT ); Mon, 11 Apr 2016 09:53:33 -0400 Subject: Re: [PATCH v6 07/10] usb: dwc3: gadget: Fix suspend/resume during dual-role mode To: Felipe Balbi References: <1460374506-9779-1-git-send-email-rogerq@ti.com> <1460374506-9779-8-git-send-email-rogerq@ti.com> <878u0knxkp.fsf@intel.com> <570BA2AA.8030308@ti.com> <87oa9gmg2k.fsf@intel.com> CC: , , , , , , , , , , From: Roger Quadros Message-ID: <570BAC4D.8010209@ti.com> Date: Mon, 11 Apr 2016 16:53:17 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <87oa9gmg2k.fsf@intel.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/04/16 16:26, Felipe Balbi wrote: > > Hi, > > Roger Quadros writes: >> On 11/04/16 15:23, Felipe Balbi wrote: >>> >>> Hi, >>> >>> Roger Quadros writes: >>>> Gadget controller might not be always active during suspend/ >>>> resume when we are operating in dual-role/otg mode. >>>> Check if we're active and only if we are then perform >>>> necessary actions during suspend/resume. >>> >>> I don't get this. If we're operating in OTG, we should have a gadget >>> driver loaded, no ? >>> >> At boot gadget driver is not automatically loaded. We're still in OTG mode >> but OTG state machine hasn't started. >> System suspend/resume can still happen. >> >> User might also load/unload the gadget driver prior to system suspend. > > good point, this should go in the -rc too. > But there is no dual-role mode currently so it won't fix any bug yet :). cheers, -roger